feat(cloudlogs): cross account bucket support #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
lorenzo-merici
commented
Mar 19, 2025
•
lorenzo-merici
commented
- Update README
- Support for cross-accounts buckets
- Support for KMS encrypted buckets
lorenzo-merici
force-pushed
the
feat-cloudtrail-sns-kms
branch
from
3383af2 to
c995794
Compare
outputs.tf
Outdated
| output "extra_permissions_kms_key" { | ||
| description = "Extra permissions to add to the KMS key policy for cross-account access" | ||
| value = module.cloud-logs.extra_permissions_kms_key | ||
| } |
There was a problem hiding this comment.
Maybe I'm missing something, but why are we exporting these outputs outside the modules?
There was a problem hiding this comment.
I have the same question here, is this used somewhere else outside the module?
lorenzo-merici
force-pushed
the
feat-cloudtrail-sns-kms
branch
from
b1a9fb9 to
aa2781f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.