-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add JobItem.FinishCode.Completed #1577
base: development
Are you sure you want to change the base?
Conversation
Thanks for the contribution! Before we can merge this, we need @fenimore to sign the Salesforce Inc. Contributor License Agreement. |
I ran the lint and type check
|
also the tests pass |
When I got to sign the CLA, it says I already did 🤷 |
I'll close and reopen this issue to see if that clears up the CLAbot issue. |
@fenimore looks like the CLA issue is clear now. Also now the checks were enabled and it looks like you just have one minor black format issue: https://github.com/tableau/server-client-python/actions/runs/13886256377/job/38851372477#step:7:16 Also, please edit this PR to target your merge to the @jacalata please review when you get a chance. |
Any luck with the CLA signing? |
@harleybl I closed and reopened this PR which caused the CLAbot to review again - and it's green now for this PR. |
@bcantoni - Thanks for actioning this. |
@fenimore please open/change PR to merge the changes to the |
In the docs here: https://help.tableau.com/current/api/rest_api/en-us/REST/rest_api_ref_jobs_tasks_and_schedules.htm#query_job
it writes:
So I opened a ticket: #1576
I think this covers the necessary changes, pretty small, I'll look into adding it to the unittest tests but I haven't gotten there yet