Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add JobItem.FinishCode.Completed #1577

Open
wants to merge 4 commits into
base: development
Choose a base branch
from

Conversation

fenimore
Copy link

@fenimore fenimore commented Mar 6, 2025

In the docs here: https://help.tableau.com/current/api/rest_api/en-us/REST/rest_api_ref_jobs_tasks_and_schedules.htm#query_job

it writes:

For bridge extract refresh jobs, a finishCode of 0 indicates that the bridge client is assigned to execute the job, while a 3
indicates that the job completed.

So I opened a ticket: #1576

I think this covers the necessary changes, pretty small, I'll look into adding it to the unittest tests but I haven't gotten there yet

Copy link

salesforce-cla bot commented Mar 6, 2025

Thanks for the contribution! Before we can merge this, we need @fenimore to sign the Salesforce Inc. Contributor License Agreement.

@fenimore
Copy link
Author

fenimore commented Mar 6, 2025

I ran the lint and type check

(py) [5.133s][master][~/access/server-client-python]$ mypy --show-error-codes --disable-error-code misc --disable-error-code import tableauserverclient test
Success: no issues found in 157 source files
(py) [15.508s][master][~/access/server-client-python]$ black --line-length 120 tableauserverclient samples test
All done! ✨ 🍰 ✨
192 files left unchanged.

@fenimore
Copy link
Author

fenimore commented Mar 6, 2025

test/test_workbook_model.py .                                       [100%]

- generated xml file: /Users/flove/access/server-client-python/test.junit.xml -
===================== 648 passed in 90.95s (0:01:30) ======================
(py) [1m31.438s][master][~/access/server-client-python]$ 

also the tests pass

@fenimore
Copy link
Author

When I got to sign the CLA, it says I already did 🤷

@bcantoni
Copy link
Contributor

I'll close and reopen this issue to see if that clears up the CLAbot issue.

@bcantoni
Copy link
Contributor

bcantoni commented Mar 16, 2025

@fenimore looks like the CLA issue is clear now. Also now the checks were enabled and it looks like you just have one minor black format issue: https://github.com/tableau/server-client-python/actions/runs/13886256377/job/38851372477#step:7:16

Also, please edit this PR to target your merge to the development branch. That's the standard destination and then we merge to master when doing a release.

@jacalata please review when you get a chance.

@harleybl
Copy link

Any luck with the CLA signing?
I am also having this issue related to the missing FinishCode in production.

@bcantoni
Copy link
Contributor

@harleybl I closed and reopened this PR which caused the CLAbot to review again - and it's green now for this PR.

@harleybl
Copy link

@bcantoni - Thanks for actioning this.

@renoyjohnm
Copy link
Contributor

@fenimore please open/change PR to merge the changes to the development branch instead of the master branch in addition to fixing the code formatting issues with black by running black . on the root of your local repo

@jacalata jacalata changed the base branch from master to development March 24, 2025 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants