Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK] Fix: Account for bigint values in engine typed data #6562

Merged
merged 2 commits into from
Mar 26, 2025

Conversation

gregfromstl
Copy link
Member

@gregfromstl gregfromstl commented Mar 26, 2025


PR-Codex overview

This PR focuses on updating the handling of wallet typed data in the thirdweb package to properly account for bigint values by replacing JSON.stringify with a custom stringify method.

Detailed summary

  • Updated import statement to include stringify from ../../utils/json.js.
  • Replaced JSON.stringify(engineData) with stringify(engineData) in the engineAccount function.
  • Modified subsequent calls to stringify for consistency in handling typed data.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@gregfromstl gregfromstl requested review from a team as code owners March 26, 2025 17:28
Copy link

vercel bot commented Mar 26, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 26, 2025 5:43pm
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 26, 2025 5:43pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 26, 2025 5:43pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 26, 2025 5:43pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 26, 2025 5:43pm

Copy link
Contributor

graphite-app bot commented Mar 26, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Mar 26, 2025
Copy link

changeset-bot bot commented Mar 26, 2025

🦋 Changeset detected

Latest commit: 3494662

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
thirdweb Patch
@thirdweb-dev/wagmi-adapter Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 47.56 KB (0%) 952 ms (0%) 145 ms (+156.23% 🔺) 1.1 s
thirdweb (cjs) 127.31 KB (0%) 2.6 s (0%) 211 ms (+36.55% 🔺) 2.8 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 113 ms (0%) 67 ms (+1074.12% 🔺) 179 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 35 ms (+1425.3% 🔺) 45 ms
thirdweb/react (minimal + tree-shaking) 19.34 KB (0%) 387 ms (0%) 96 ms (+450.04% 🔺) 483 ms

@gregfromstl gregfromstl added the merge-queue Adds the pull request to Graphite's merge queue. label Mar 26, 2025
Copy link

codecov bot commented Mar 26, 2025

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 55.06%. Comparing base (9c1c5f2) to head (3494662).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/thirdweb/src/wallets/engine/index.ts 25.00% 3 Missing ⚠️

❌ Your patch status has failed because the patch coverage (25.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6562      +/-   ##
==========================================
- Coverage   55.07%   55.06%   -0.01%     
==========================================
  Files         883      883              
  Lines       55362    55363       +1     
  Branches     3789     3785       -4     
==========================================
- Hits        30491    30488       -3     
- Misses      24776    24780       +4     
  Partials       95       95              
Flag Coverage Δ
packages 55.06% <25.00%> (-0.01%) ⬇️
Files with missing lines Coverage Δ
packages/thirdweb/src/wallets/engine/index.ts 12.90% <25.00%> (+0.70%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member Author

gregfromstl commented Mar 26, 2025

Merge activity

  • Mar 26, 1:37 PM EDT: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Mar 26, 1:37 PM EDT: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Mar 26, 2:17 PM EDT: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.

@gregfromstl gregfromstl merged commit e5026a1 into main Mar 26, 2025
31 of 32 checks passed
@gregfromstl gregfromstl deleted the greg/fix-engine-wallet-stringify branch March 26, 2025 18:10
@joaquim-verges joaquim-verges mentioned this pull request Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-queue Adds the pull request to Graphite's merge queue. packages SDK Involves changes to the thirdweb SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants