-
Notifications
You must be signed in to change notification settings - Fork 512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SDK] Fix: Account for bigint values in engine typed data #6562
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
🦋 Changeset detectedLatest commit: 3494662 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (25.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #6562 +/- ##
==========================================
- Coverage 55.07% 55.06% -0.01%
==========================================
Files 883 883
Lines 55362 55363 +1
Branches 3789 3785 -4
==========================================
- Hits 30491 30488 -3
- Misses 24776 24780 +4
Partials 95 95
🚀 New features to boost your workflow:
|
Merge activity
|
PR-Codex overview
This PR focuses on updating the handling of wallet typed data in the
thirdweb
package to properly account forbigint
values by replacingJSON.stringify
with a customstringify
method.Detailed summary
import
statement to includestringify
from../../utils/json.js
.JSON.stringify(engineData)
withstringify(engineData)
in theengineAccount
function.stringify
for consistency in handling typed data.