Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new narrative #6563

Merged
merged 1 commit into from
Mar 27, 2025
Merged

new narrative #6563

merged 1 commit into from
Mar 27, 2025

Conversation

saminacodes
Copy link
Member

@saminacodes saminacodes commented Mar 27, 2025


PR-Codex overview

This PR focuses on updating the AnnouncementBanner and Banner components to reflect changes related to a new payment feature, the Universal Bridge. It also enhances documentation regarding webhook configurations and modifies feature descriptions to better convey the new functionalities.

Detailed summary

  • Updated AnnouncementBanner with new href, label, and trackingLabel.
  • Changed Banner properties: updated id, text, and href.
  • Revised documentation in page.mdx to reflect changes from Pay to Universal Bridge.
  • Enhanced feature descriptions in page.mdx to clarify functionalities.
  • Removed old fee sharing section from page.mdx.
  • Added new integration options in the page.mdx.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@saminacodes saminacodes requested review from a team as code owners March 27, 2025 03:26
Copy link

changeset-bot bot commented Mar 27, 2025

⚠️ No Changeset found

Latest commit: ab738eb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Mar 27, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 27, 2025 3:01pm
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 27, 2025 3:01pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 27, 2025 3:01pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 27, 2025 3:01pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 27, 2025 3:01pm

Copy link
Contributor

graphite-app bot commented Mar 27, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Mar 27, 2025
@github-actions github-actions bot added the Portal Involves changes to the Portal (docs) codebase. label Mar 27, 2025
@vercel vercel bot temporarily deployed to Preview – wallet-ui March 27, 2025 03:27 Inactive
@vercel vercel bot temporarily deployed to Preview – login March 27, 2025 03:27 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www March 27, 2025 03:27 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground March 27, 2025 03:27 Inactive
Copy link

codecov bot commented Mar 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.07%. Comparing base (8e6651e) to head (ab738eb).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6563   +/-   ##
=======================================
  Coverage   55.07%   55.07%           
=======================================
  Files         883      883           
  Lines       55363    55363           
  Branches     3796     3796           
=======================================
  Hits        30493    30493           
  Misses      24775    24775           
  Partials       95       95           
Flag Coverage Δ
packages 55.07% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

github-actions bot commented Mar 27, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 47.56 KB (0%) 952 ms (0%) 172 ms (+214.1% 🔺) 1.2 s
thirdweb (cjs) 127.31 KB (0%) 2.6 s (0%) 261 ms (+75.26% 🔺) 2.9 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 113 ms (0%) 105 ms (+2268.03% 🔺) 217 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 74 ms (+2200.84% 🔺) 84 ms
thirdweb/react (minimal + tree-shaking) 19.34 KB (0%) 387 ms (0%) 114 ms (+734.32% 🔺) 501 ms

@vercel vercel bot temporarily deployed to Preview – docs-v2 March 27, 2025 14:35 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui March 27, 2025 14:35 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground March 27, 2025 14:35 Inactive
@vercel vercel bot temporarily deployed to Preview – login March 27, 2025 14:35 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www March 27, 2025 14:36 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground March 27, 2025 14:36 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui March 27, 2025 14:36 Inactive
@vercel vercel bot temporarily deployed to Preview – login March 27, 2025 14:36 Inactive
@saminacodes saminacodes added the merge-queue Adds the pull request to Graphite's merge queue. label Mar 27, 2025
Copy link
Member Author

saminacodes commented Mar 27, 2025

Merge activity

  • Mar 27, 10:54 AM EDT: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Mar 27, 10:54 AM EDT: saminacodes added this pull request to the Graphite merge queue.
  • Mar 27, 11:02 AM EDT: A user merged this pull request with the Graphite merge queue.

<!--

## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

## How to test

Unit tests, playground, etc.

-->

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on updating the `AnnouncementBanner` and `Banner` components to promote the new `Universal Bridge` feature, enhancing the messaging around payment integration, and refining the content in the documentation to reflect these changes.

### Detailed summary
- Updated `AnnouncementBanner` with new `href`, `label`, and `trackingLabel`.
- Changed `Banner` ID, `text`, and `href` to reflect the `Universal Bridge` launch.
- Revised documentation for webhook events to include `Universal Bridge`.
- Enhanced content in the overview page for `Universal Bridge`.
- Updated descriptions and titles for multiple `FeatureCard` components.
- Removed fee-sharing section and added new integration options for `Universal Bridge`.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard. Portal Involves changes to the Portal (docs) codebase.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants