Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEB-148] Do not add active chain to nebula context by default #6564

Merged
merged 1 commit into from
Mar 27, 2025

Conversation

MananTank
Copy link
Member

@MananTank MananTank commented Mar 27, 2025

PR-Codex overview

This PR focuses on simplifying the ChatPageContent component by removing the dependency on the active wallet chain, which is no longer used. This change may streamline the component's logic and improve maintainability.

Detailed summary

  • Removed import of useActiveWalletChain from thirdweb/react.
  • Eliminated the activeChain variable and its usage in the component.
  • Updated dependency array in the useEffect hook to exclude activeChain.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

linear bot commented Mar 27, 2025

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground March 27, 2025 11:07 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 March 27, 2025 11:07 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui March 27, 2025 11:07 Inactive
Copy link

vercel bot commented Mar 27, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 27, 2025 7:05pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Mar 27, 2025 7:05pm
login ⬜️ Skipped (Inspect) Mar 27, 2025 7:05pm
thirdweb_playground ⬜️ Skipped (Inspect) Mar 27, 2025 7:05pm
wallet-ui ⬜️ Skipped (Inspect) Mar 27, 2025 7:05pm

@vercel vercel bot temporarily deployed to Preview – login March 27, 2025 11:07 Inactive
Copy link

changeset-bot bot commented Mar 27, 2025

⚠️ No Changeset found

Latest commit: 3b827ea

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Mar 27, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@MananTank MananTank marked this pull request as ready for review March 27, 2025 11:07
@MananTank MananTank requested review from a team as code owners March 27, 2025 11:07
Copy link

codecov bot commented Mar 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.05%. Comparing base (2231db7) to head (3b827ea).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6564   +/-   ##
=======================================
  Coverage   55.05%   55.05%           
=======================================
  Files         883      883           
  Lines       55361    55361           
  Branches     3786     3786           
=======================================
  Hits        30481    30481           
  Misses      24785    24785           
  Partials       95       95           
Flag Coverage Δ
packages 55.05% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

github-actions bot commented Mar 27, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 47.56 KB (0%) 952 ms (0%) 198 ms (+94.06% 🔺) 1.2 s
thirdweb (cjs) 127.31 KB (0%) 2.6 s (0%) 288 ms (+16.13% 🔺) 2.9 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 113 ms (0%) 103 ms (+1070.45% 🔺) 215 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 47 ms (+1632.97% 🔺) 57 ms
thirdweb/react (minimal + tree-shaking) 19.34 KB (0%) 387 ms (0%) 137 ms (+477.36% 🔺) 523 ms

Copy link
Contributor

graphite-app bot commented Mar 27, 2025

Merge activity

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground March 27, 2025 18:58 Inactive
@vercel vercel bot temporarily deployed to Preview – login March 27, 2025 18:58 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 March 27, 2025 18:58 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui March 27, 2025 18:58 Inactive
@graphite-app graphite-app bot merged commit 3b827ea into main Mar 27, 2025
32 checks passed
@graphite-app graphite-app bot deleted the neb-148 branch March 27, 2025 19:06
@vercel vercel bot temporarily deployed to Production – docs-v2 March 27, 2025 19:06 Inactive
@vercel vercel bot temporarily deployed to Production – login March 27, 2025 19:06 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground March 27, 2025 19:06 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants