-
Notifications
You must be signed in to change notification settings - Fork 512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix "Cannot read properties of undefined (reading 'forwardRef')" error on certain bundler setups #6569
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 43af4fc The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
packages/thirdweb/src/react/web/ui/MediaRenderer/MediaRenderer.tsx
Outdated
Show resolved
Hide resolved
Fixes #6481 |
size-limit report 📦
|
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (37.27%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #6569 +/- ##
==========================================
- Coverage 55.07% 55.05% -0.02%
==========================================
Files 883 883
Lines 55363 55361 -2
Branches 3796 3786 -10
==========================================
- Hits 30493 30481 -12
- Misses 24775 24785 +10
Partials 95 95
🚀 New features to boost your workflow:
|
PR-Codex overview
This PR addresses a bug related to reading properties of
undefined
in certain bundler setups by modifying theMediaRenderer
component and its associated players.Detailed summary
React
to type-only import.MediaRenderer
to useforwardRef
correctly.