-
Notifications
You must be signed in to change notification settings - Fork 514
[Portal] Add cross-chain swapping guide and add bridge submodules #6571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
<Step title='Install the Connect SDK'> | ||
<InstallTabs | ||
npm="npm i thirdweb" | ||
yarn="yarn install thirdweb" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The yarn command is incorrect. It should be yarn add thirdweb
rather than yarn install thirdweb
. The install
command in yarn is used to install all dependencies from package.json, while add
is used to add a specific package.
yarn="yarn install thirdweb" | |
yarn="yarn add thirdweb" |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
size-limit report 📦
|
dd2b5f3
to
8761fb1
Compare
<Callout variant="info"> | ||
The `Buy` namespace is purpose-built for when you want to obtain a specific amount of the output token. | ||
If you have a specific input amount and are flexible on the output amount, you can use the `Sell` namespace. | ||
Learn more about sells [here]( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Callout component contains an incomplete URL reference. The markdown link is missing its URL and closing parenthesis. Please complete the link with the appropriate destination URL:
Learn more about sells [here](https://portal.thirdweb.com/connect/pay/guides/cross-chain-swapping)
Or another appropriate URL that explains the Sell namespace functionality.
Learn more about sells [here]( | |
Learn more about sells [here](https://portal.thirdweb.com/connect/pay/guides/cross-chain-swapping) |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
8761fb1
to
4ceff95
Compare
4ceff95
to
38f79b7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6571 +/- ##
=======================================
Coverage 55.05% 55.06%
=======================================
Files 883 883
Lines 55361 55361
Branches 3786 3787 +1
=======================================
+ Hits 30481 30486 +5
+ Misses 24785 24780 -5
Partials 95 95
🚀 New features to boost your workflow:
|
Merge activity
|
) <!-- ## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes" If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000): ## Notes for the reviewer Anything important to call out? Be sure to also clarify these in your comments. ## How to test Unit tests, playground, etc. --> <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on enhancing the documentation and functionality surrounding the `thirdweb` Universal Bridge, particularly for cross-chain swapping and related features. It updates guides, introduces new functionalities, and improves the clarity of the code. ### Detailed summary - Updated `yarn` command in `page.mdx` for installing `thirdweb`. - Renamed the guide from "Build a Custom Experience" to "Build a Custom Onramp Experience" in `sidebar.tsx`. - Added a new guide for "Cross-Chain Swapping" in `page.mdx`. - Enhanced tag filtering in `slugs.ts` to include `@bridge`. - Updated comments in `Buy.ts` and `Sell.ts` to specify `@bridge Buy` and `@bridge Sell`. - Improved sidebar link generation in `getSidebarLinkGroups.ts` to include `@bridge` links. - Added comprehensive steps for cross-chain swapping in the new guide, including installation, obtaining quotes, preparing transactions, and checking swap status. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
9e08f7a
to
d4f5a9d
Compare
PR-Codex overview
This PR focuses on enhancing the documentation and functionality related to cross-chain swapping using the
thirdweb
Universal Bridge, including updates to existing guides and the introduction of new examples for better user understanding.Detailed summary
yarn
command inpage.mdx
for installingthirdweb
.@bridge
.Buy.ts
andSell.ts
to specify@bridge
with respective namespaces.cross-chain-swapping/page.mdx
, including:Bridge
namespace for cross-chain operations.