Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tutorial routes from framer rewrites #6592

Merged
merged 1 commit into from
Mar 31, 2025

Conversation

jnsdls
Copy link
Member

@jnsdls jnsdls commented Mar 31, 2025

closes: CORE-802

Redirect /learn/tutorials to /learn/guides

This PR removes /learn/tutorials and /learn/tutorials/:tutorial_slug from the framer-rewrites list and adds redirects from these paths to their corresponding /learn/guides equivalents.


PR-Codex overview

This PR focuses on updating the routing structure for the /learn/tutorials paths, redirecting them to /learn/guides instead. This change improves the organization of the dashboard's navigation.

Detailed summary

  • Removed routes for "/learn/tutorials" and "/learn/tutorials/:tutorial_slug" in apps/dashboard/framer-rewrites.js.
  • Added redirects in apps/dashboard/redirects.js:
    • Redirect all /learn/tutorials and sub-routes to /learn/guides.
    • Two new entries for redirecting /learn/tutorials/:path* and /learn/tutorials to /learn/guides.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Mar 31, 2025

⚠️ No Changeset found

Latest commit: 647f780

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – wallet-ui March 31, 2025 17:00 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 March 31, 2025 17:00 Inactive
Copy link

vercel bot commented Mar 31, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 31, 2025 5:20pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Mar 31, 2025 5:20pm
login ⬜️ Skipped (Inspect) Mar 31, 2025 5:20pm
thirdweb_playground ⬜️ Skipped (Inspect) Mar 31, 2025 5:20pm
wallet-ui ⬜️ Skipped (Inspect) Mar 31, 2025 5:20pm

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground March 31, 2025 17:00 Inactive
@vercel vercel bot temporarily deployed to Preview – login March 31, 2025 17:00 Inactive
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Mar 31, 2025
Copy link
Member Author

jnsdls commented Mar 31, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@jnsdls jnsdls force-pushed the Remove_tutorial_routes_from_framer_rewrites branch from b5ffd73 to 647f780 Compare March 31, 2025 17:01
Copy link

codecov bot commented Mar 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.96%. Comparing base (fb70cab) to head (a5f005f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6592   +/-   ##
=======================================
  Coverage   54.96%   54.96%           
=======================================
  Files         885      885           
  Lines       55517    55517           
  Branches     3793     3793           
=======================================
  Hits        30513    30513           
  Misses      24911    24911           
  Partials       93       93           
Flag Coverage Δ
packages 54.96% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vercel vercel bot temporarily deployed to Preview – docs-v2 March 31, 2025 17:02 Inactive
@vercel vercel bot temporarily deployed to Preview – login March 31, 2025 17:02 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui March 31, 2025 17:02 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground March 31, 2025 17:02 Inactive
@jnsdls jnsdls marked this pull request as ready for review March 31, 2025 17:02
@jnsdls jnsdls requested review from a team as code owners March 31, 2025 17:02
Copy link

linear bot commented Mar 31, 2025

Copy link
Contributor

github-actions bot commented Mar 31, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 47.56 KB (0%) 952 ms (0%) 149 ms (+155.02% 🔺) 1.1 s
thirdweb (cjs) 127.31 KB (0%) 2.6 s (0%) 187 ms (+16.85% 🔺) 2.8 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 113 ms (0%) 78 ms (+811.7% 🔺) 190 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 34 ms (+1716.79% 🔺) 44 ms
thirdweb/react (minimal + tree-shaking) 19.34 KB (0%) 387 ms (0%) 81 ms (+457.97% 🔺) 467 ms

Copy link
Contributor

graphite-app bot commented Mar 31, 2025

Merge activity

closes: CORE-802

Redirect `/learn/tutorials` to `/learn/guides`

This PR removes `/learn/tutorials` and `/learn/tutorials/:tutorial_slug` from the framer-rewrites list and adds redirects from these paths to their corresponding `/learn/guides` equivalents.
@graphite-app graphite-app bot force-pushed the Remove_tutorial_routes_from_framer_rewrites branch from 647f780 to a5f005f Compare March 31, 2025 17:14
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground March 31, 2025 17:14 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 March 31, 2025 17:14 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui March 31, 2025 17:14 Inactive
@vercel vercel bot temporarily deployed to Preview – login March 31, 2025 17:14 Inactive
@graphite-app graphite-app bot merged commit a5f005f into main Mar 31, 2025
32 checks passed
@graphite-app graphite-app bot deleted the Remove_tutorial_routes_from_framer_rewrites branch March 31, 2025 17:21
@vercel vercel bot temporarily deployed to Production – docs-v2 March 31, 2025 17:21 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground March 31, 2025 17:21 Inactive
@vercel vercel bot temporarily deployed to Production – login March 31, 2025 17:21 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui March 31, 2025 17:21 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants