[SDK] Feature: Adds action field to Bridge transactions #6613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
size-limit report 📦
|
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com> Signed-off-by: greg <gregfromstl@gmail.com>
🦋 Changeset detectedLatest commit: 1d3136b The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com> Signed-off-by: greg <gregfromstl@gmail.com>
…ttps://github.com/thirdweb-dev/js into greg/tool-3900-add-transaction-actions-to-the-sdk
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6613 +/- ##
=======================================
Coverage 54.92% 54.93%
=======================================
Files 885 885
Lines 55577 55584 +7
Branches 3795 3796 +1
=======================================
+ Hits 30526 30533 +7
Misses 24956 24956
Partials 95 95
🚀 New features to boost your workflow:
|
| @@ -35,4 +36,16 @@ describe.runIf(process.env.TW_SECRET_KEY)("Bridge.status", () => { | |||
| } | |||
| `); | |||
| }); | |||
|
|
|||
| it("should handle successfull status with chain", async () => { | |||
There was a problem hiding this comment.
There's a typo in the test description - "successfull" should be "successful".
Suggested change
| it("should handle successfull status with chain", async () => { | |
| it("should handle successful status with chain", async () => { |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
joaquim-verges
approved these changes
Apr 1, 2025
joaquim-verges
deleted the
greg/tool-3900-add-transaction-actions-to-the-sdk
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR focuses on enhancing the
Bridgefunctionality by addingactionfields to transaction responses and improving the handling of bridge statuses, including new tests and type definitions.Detailed summary
actionfield to transaction types inQuote.ts.statusfunction inStatus.tsto handle optionalchainId.Status.test.ts.id,client, andchaininBuy.tsandSell.ts.