Skip to content

Dashboard: Remove chakra usage from contract analytics page, style tweaks #6661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

MananTank
Copy link
Member

@MananTank MananTank commented Apr 5, 2025


PR-Codex overview

This PR focuses on enhancing the ContractAnalyticsPage by improving chart components and refactoring the analytics display logic. It introduces better formatting for tooltips and updates the UI for displaying analytics data.

Detailed summary

  • Added toolTipLabelFormatter function for improved date formatting in charts.
  • Updated ThirdwebBarChart components to include titleClassName, hideLabel, and toolTipLabelFormatter.
  • Refactored AnalyticsStat and AnalyticsData components to streamline data display.
  • Replaced Suspense with direct rendering of AnalyticsData.
  • Introduced AnalyticsStatUI for cleaner presentation of analytics data.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Apr 5, 2025

⚠️ No Changeset found

Latest commit: f2abc8b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – login April 5, 2025 13:25 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 April 5, 2025 13:25 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground April 5, 2025 13:25 Inactive
Copy link

vercel bot commented Apr 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 5, 2025 2:37pm
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 5, 2025 2:37pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 5, 2025 2:37pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 5, 2025 2:37pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 5, 2025 2:37pm

@vercel vercel bot temporarily deployed to Preview – wallet-ui April 5, 2025 13:25 Inactive
@MananTank MananTank marked this pull request as ready for review April 5, 2025 13:26
@MananTank MananTank requested review from a team as code owners April 5, 2025 13:26
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Apr 5, 2025
Copy link
Member Author

MananTank commented Apr 5, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

codecov bot commented Apr 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.05%. Comparing base (386138e) to head (f2abc8b).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6661   +/-   ##
=======================================
  Coverage   55.05%   55.05%           
=======================================
  Files         889      889           
  Lines       55858    55858           
  Branches     3822     3822           
=======================================
  Hits        30751    30751           
  Misses      25012    25012           
  Partials       95       95           
Flag Coverage Δ
packages 55.05% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

github-actions bot commented Apr 5, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 47.57 KB (0%) 952 ms (0%) 135 ms (+115.61% 🔺) 1.1 s
thirdweb (cjs) 129.95 KB (0%) 2.6 s (0%) 202 ms (+22.5% 🔺) 2.9 s
thirdweb (minimal + tree-shaking) 5.62 KB (0%) 113 ms (0%) 62 ms (+1221.21% 🔺) 174 ms
thirdweb/chains (tree-shaking) 514 B (0%) 11 ms (0%) 36 ms (+1597.48% 🔺) 46 ms
thirdweb/react (minimal + tree-shaking) 19.37 KB (0%) 388 ms (0%) 70 ms (+408.05% 🔺) 457 ms

@graphite-app graphite-app bot changed the base branch from 04-05-dashboard_team_invoices_page_style_tweaks to graphite-base/6661 April 5, 2025 13:53
@graphite-app graphite-app bot force-pushed the graphite-base/6661 branch from e5ad4e1 to 386138e Compare April 5, 2025 14:00
@graphite-app graphite-app bot force-pushed the 04-05-dashboard_remove_chakra_usage_from_contract_analytics_page_style_tweaks branch from 82ab782 to 8fb51ad Compare April 5, 2025 14:00
@vercel vercel bot temporarily deployed to Preview – wallet-ui April 5, 2025 14:00 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground April 5, 2025 14:00 Inactive
@vercel vercel bot temporarily deployed to Preview – login April 5, 2025 14:00 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 April 5, 2025 14:00 Inactive
@graphite-app graphite-app bot changed the base branch from graphite-base/6661 to main April 5, 2025 14:01
@graphite-app graphite-app bot force-pushed the 04-05-dashboard_remove_chakra_usage_from_contract_analytics_page_style_tweaks branch from 8fb51ad to 42ecad1 Compare April 5, 2025 14:01
@vercel vercel bot temporarily deployed to Preview – login April 5, 2025 14:01 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui April 5, 2025 14:01 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground April 5, 2025 14:01 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 April 5, 2025 14:01 Inactive
@jnsdls jnsdls merged commit a3b4720 into main Apr 7, 2025
29 checks passed
@jnsdls jnsdls deleted the 04-05-dashboard_remove_chakra_usage_from_contract_analytics_page_style_tweaks branch April 7, 2025 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants