Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ts-support): add typescript support #37

Merged
merged 4 commits into from
Dec 3, 2020

Conversation

acidicX
Copy link
Contributor

@acidicX acidicX commented May 10, 2019

Hi, thanks a lot for publishing this great React tutorial!

I integrated TypeScript exercise files with this PR. I know it might be a hacky solution, but it's just a proof of concept and I did not want to change the whole URL structure etc.

Let me know what you think @tyroprogrammer !

@karlhorky
Copy link
Contributor

Nice one @acidicX ! If you merge in my changes in 5c60d9d from master, I suppose the tests will pass?

@acidicX
Copy link
Contributor Author

acidicX commented Jun 3, 2019

@karlhorky you're welcome ;) done!

Copy link
Owner

@tyroprogrammer tyroprogrammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this.

@tyroprogrammer tyroprogrammer merged commit a41485e into tyroprogrammer:master Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants