[trello.com/c/sG80IZan] delay badge update for current chat #872
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lainaaa
reviewed
May 28, 2025
Member
Lainaaa
left a comment
Lainaaa
left a comment
There was a problem hiding this comment.
Should not it be easier just to make Task.sleep instead of this hard logic?
vovameister
force-pushed
the
trello.com/c/sG80IZan
branch
from
64d1e1c to
0140920
Compare
Member
Author
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR delays the badge update for the current chat to prevent immediate changes when a user is actively reading messages.
- Introduces a new property to track the currently selected chat room.
- Implements a debounced badge update using a new ObservableSender subject.
- Adds a delay constant to control the update timing.
Comments suppressed due to low confidence (1)
Adamant/Modules/ChatsList/ChatListViewController.swift:1697
- The variable name 'currentChatBudgeUpdateDelay' appears to contain a spelling mistake; consider renaming it to 'currentChatBadgeUpdateDelay' for clarity.
fileprivate let currentChatBudgeUpdateDelay: TimeInterval = 1.0
art-divin
reviewed
May 28, 2025
| case let c where c == chatsController: | ||
| tableView.endUpdates() | ||
|
|
||
| case let c where c == unreadController: |
Collaborator
There was a problem hiding this comment.
just for the sake of clarity, we can rename c to controller as intended
art-divin
approved these changes
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.