Schema.create() for TypeScript type inference #15482
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The key idea behind fixing #14954 and related issues is to infer the raw document type and hydrated document type directly from the schema definition, rather than attempting to infer the hydrated document type from the raw document type. The new
Schema.create()
function does just that.We did some work attempting to pull this logic into
new Schema()
directly in 9.0...vkarpov15/gh-14954-scratch-2, but unfortunately that would require shifting around the generic params tonew Schema()
significantly - we would have to makeTSchemaDefinition
the first generic param, which would break anyone who is usingnew Schema<RawDoc>()
.@hasezoey can you try out
Schema.create()
in Typegoose and see what happens?Examples