Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic code arrangement #157

Merged

Conversation

adimosh
Copy link
Contributor

@adimosh adimosh commented Jul 11, 2022

Removed a lot of useless whitespace, unused usings, attempted to create a usable editorconfig file.

@rstm-sf
Copy link
Collaborator

rstm-sf commented Jul 11, 2022

Relying only on Visual Studio formatting is not really the right solution, as Rider/Resharper has different settings (broader?) and does not support all the formatting that is specified in the .editorconfig from the Studio. Perhaps a good idea would be to look towards the dotnet-format

@adimosh
Copy link
Contributor Author

adimosh commented Jul 11, 2022

While that may be true, the current state of the code does not implement anything, and the code is full of unused whitespace. While I can definitely use R# to make something better, I have seen no indication that the project collaborators intended that to be the case.

@adimosh
Copy link
Contributor Author

adimosh commented Jul 11, 2022

@rstm-sf - would me removing the editorconfig file from this PR make it more merge-worthy? It's basically just code cleanup and wants to be nothing more.

@304NotModified
Copy link
Member

I think this is a nice improvement:)

Haven't checked it indepth yet

@304NotModified
Copy link
Member

I think this is a nice improvement. Checked that this only a whitespace changes (and also removed some unneeded imports and fixed comment typos, so nice)

@304NotModified 304NotModified merged commit 53af842 into CharsetDetector:master Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants