wip(android): add Android SDK and FlexHybridApp-Android #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinGrafstrom
force-pushed
the
fix-android-sdk
branch
from
16e1adc to
bca838e
Compare
aerovulpe
requested changes
Apr 2, 2025
There was a problem hiding this comment.
@KevinGrafstrom let's separate the example from the library project and move it into example.
| } | ||
|
|
||
| android { | ||
| namespace = "com.chatkitty.chatkittyui" |
There was a problem hiding this comment.
Let's change the namespace (including subpackages) from com.chatkitty.chatkittyui to com.chatkitty.ui.
| } | ||
|
|
||
| defaultConfig { | ||
| applicationId = "com.chatkitty.chatkittyui" |
| android:name=".MainActivity" | ||
| android:exported="true" | ||
| android:label="@string/app_name" | ||
| android:theme="@style/Theme.ChatKittyUI"> |
There was a problem hiding this comment.
Let's rename the theme to ChatUi
| @@ -0,0 +1,62 @@ | |||
| package com.chatkitty.chatkittyui | |||
There was a problem hiding this comment.
This should be under examples/android
| @@ -0,0 +1,3 @@ | |||
| <resources> | |||
| publishing { | ||
| publications { | ||
| create<MavenPublication>("mavenJava") { | ||
| groupId = "com.chatkitty.uie" |
aerovulpe
reviewed
Apr 3, 2025
|
|
||
| override fun <T : Any> onMessage(id: String?, type: FlexStompXEventType, payload: T) { | ||
| flexWebView.evalFlexFunc("onMessage", messageToBase64(FlexStompXMessage(id, type.value, payload))) | ||
| Log.i("gnw", "onMessage finished with a payload: ${payload}") |
aerovulpe
reviewed
Apr 3, 2025
| } else { | ||
| "standalone" | ||
| } | ||
| val connection = "shared" |
KevinGrafstrom
force-pushed
the
fix-android-sdk
branch
from
cfba439 to
9abb993
Compare
aerovulpe
approved these changes
Apr 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ChatKitty's Chat UI should be easily usable in other people's Android apps. To make it easier, we are making an Android library so that other developers can simply add the Chat UI component to their app. This pull request adds an Android Studio project which contains the Android Chat UI component. This pull request also adds the FlexHybridApp-Android library since its repository has not been updated in years. For that reason, we want to include it in our repository so that we can maintain it. FlexHybridApp-Android is a library which allows for communication between a Web View and the native Android device. It is used in the Android Chat UI component to deliver notifications from the Phoenix app in the Web View to the Android device.