Complete sumAll challenge

Author: ChiselD

sumAll/sumAll.js

@@ -1,5 +1,29 @@
-const sumAll = function() {
-
+const sumAll = function(a, b) {
+	// Test for invalid arguments
+	if (a <= 0 || b <= 0) {
+		return "ERROR";
+	}
+	if (parseInt(a) !== a || parseInt(b) !== b) {
+		return "ERROR";
+	}
+	// Define variables
+	let all = [];
+	let i, n;
+	// Figure out which argument is smaller
+	if (a < b) {
+		i = a;
+		n = b;
+	} else {
+		i = b;
+		n = a;
+	}
+	// Create array of all numbers in range
+	for (; i <= n; i++) {
+		all.push(i);
+	}
+	// Sum up numbers in range and return sum
+	let sum = all.reduce((x, y) => x += y);
+	return sum;
 }
 
 module.exports = sumAll

sumAll/sumAll.spec.js

@@ -4,19 +4,19 @@ describe('sumAll', function() {
   it('sums numbers within the range', function() {
     expect(sumAll(1, 4)).toEqual(10);
   });
-  xit('works with large numbers', function() {
+  it('works with large numbers', function() {
     expect(sumAll(1, 4000)).toEqual(8002000);
   });
-  xit('works with larger number first', function() {
+  it('works with larger number first', function() {
     expect(sumAll(123, 1)).toEqual(7626);
   });
-  xit('returns ERROR with negative numbers', function() {
+  it('returns ERROR with negative numbers', function() {
     expect(sumAll(-10, 4)).toEqual('ERROR');
   });
-  xit('returns ERROR with non-number parameters', function() {
+  it('returns ERROR with non-number parameters', function() {
     expect(sumAll(10, "90")).toEqual('ERROR');
   });
-  xit('returns ERROR with non-number parameters', function() {
+  it('returns ERROR with non-number parameters', function() {
     expect(sumAll(10, [90, 1])).toEqual('ERROR');
   });
 });