Skip to content

Translate examples #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
niccokunzmann opened this issue May 7, 2017 · 3 comments
Closed

Translate examples #24

niccokunzmann opened this issue May 7, 2017 · 3 comments

Comments

@niccokunzmann
Copy link
Member

Website-link: https://coderdojopotsdam.github.io/regex-tutorial/steps/03-03-or.html and more

Expected Behavior

I expect the English tutorial to use English examples.

Actual Behavior

Some of the examples given are stillin German.

Solution Description

Find appropriate English examples.
The poem Ottos Mops has English equivalents.

Hints

niccokunzmann added a commit that referenced this issue Jul 12, 2017
translate the poem
niccokunzmann added a commit that referenced this issue Jul 12, 2017
translate the poem
@weerox
Copy link
Contributor

weerox commented Jul 14, 2017

I was looking at 03-01-or and saw earlier PRs and issues discussing this and whether we should use names of cities or use compound words instead, but never really understood what conclusion you came to

@weerox
Copy link
Contributor

weerox commented Jul 14, 2017

I decided to go with city names

@niccokunzmann
Copy link
Member Author

As I see it, all English tutorial is English now. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants