Skip to content

Update 03-02-or.html #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 11, 2017
Merged

Conversation

orcutt989
Copy link
Contributor

@orcutt989 orcutt989 commented May 11, 2017

I do not think native English speakers know to look for "hausen" or "roda". Maybe explain why you would use those. I only think to try |bach or bach| but don't know what to put on the other side of the logic operator.

The instructions say to look for words with "bach" in them. Why would I look for "hausen" or "roda" ? Perhaps this is knowledge only a person living in Germany would know.

Part of #29

I do not think native English speakers know to look for "hausen" or "roda". Maybe explain why you would use those. I only think to try ```|bach``` or ```bach|``` but don't know what to put on the other side of the logic operator. 

The instructions say to look for words with "bach" in them. Why would I look for "hausen" or "roda" ?
@niccokunzmann
Copy link
Member

niccokunzmann commented May 11, 2017

Great idea. I would say, we can use English cities.

  • Nottingham
  • Birmingham
  • New York
  • New Orleans
  • London
  • ...

What do you think?
They could look for "ham" and "New"

@niccokunzmann niccokunzmann mentioned this pull request May 11, 2017
2 tasks
@niccokunzmann niccokunzmann merged commit 79ec60e into CoderDojoPotsdam:master May 11, 2017
@orcutt989
Copy link
Contributor Author

orcutt989 commented May 11, 2017

@niccokunzmann The easiest thing to do would be to just add the words "find bach, roda, and hausen", but right now this test is dependent on localization and English literacy. I think that the only requirement for this tutorial should be English literacy, not necesarilly localization. Its possible that there are English speakers that would not be familiar with those names as well.

I would suggest chagning the test from city names to compound words instead. For example...

Find words that contain the words "any" or "battle" or "dog".

anybody
doghouse
anyhow
cookbook
anyone
dogwood
anyplace
firsthand
battlecruiser
battleship
grapevine
battlecry

This way you dont have to worry about the reader's competency of where they live, but instead their English comptetency which is the point of the English tutorial.

@orcutt989 orcutt989 deleted the patch-3 branch May 11, 2017 18:59
@niccokunzmann
Copy link
Member

@orcutt989 Sounds good to me.

@niccokunzmann
Copy link
Member

Let's discuss in #37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants