Skip to content

Commit 350fe54

Browse files
committed
dont install enthought.traits
svn path=/trunk/matplotlib/; revision=5431
1 parent 8b278ab commit 350fe54

File tree

4 files changed

+25
-13
lines changed

4 files changed

+25
-13
lines changed

CHANGELOG

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
1+
2008-06-09 Don't install Enthought.Traits along with matplotlib. For
2+
matplotlib developers convenience, it can still be
3+
installed by setting an option in setup.cfg while we figure
4+
decide if there is a future for the traited config - DSD
5+
16
2008-06-09 Added range keyword arg to hist() - MM
27

38
2008-06-07 Moved list of backends to rcsetup.py; made use of lower

lib/matplotlib/artist.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -179,7 +179,7 @@ def contains(self,mouseevent):
179179
def set_contains(self,picker):
180180
"""Replace the contains test used by this artist. The new picker should
181181
be a callable function which determines whether the artist is hit by the
182-
mouse event:
182+
mouse event::
183183
184184
hit, props = picker(artist, mouseevent)
185185

setup.cfg.template

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,8 @@ tag_svn_revision = 1
2525
#pytz = False
2626
#dateutil = False
2727
#
28-
## Experimental config package support:
28+
## Experimental config package support, this should only be enabled by
29+
## matplotlib developers, for matplotlib development
2930
#enthought.traits = False
3031
#configobj = False
3132

setupext.py

Lines changed: 17 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@
106106
'provide_pytz': 'auto',
107107
'provide_dateutil': 'auto',
108108
'provide_configobj': 'auto',
109-
'provide_traits': 'auto',
109+
'provide_traits': False,
110110
'build_agg': True,
111111
'build_gtk': 'auto',
112112
'build_gtkagg': 'auto',
@@ -141,7 +141,7 @@
141141

142142
try: options['provide_traits'] = config.getboolean("provide_packages",
143143
"enthought.traits")
144-
except: options['provide_traits'] = 'auto'
144+
except: options['provide_traits'] = False
145145

146146
try: options['build_gtk'] = config.getboolean("gui_support", "gtk")
147147
except: options['build_gtk'] = 'auto'
@@ -462,9 +462,11 @@ def check_provide_configobj():
462462
return False
463463

464464
def check_provide_traits():
465-
if options['provide_traits'] is True:
466-
print_status("enthought.traits", "matplotlib will provide")
467-
return True
465+
# Let's not install traits by default for now, unless it is specifically
466+
# asked for in setup.cfg AND it is not already installed
467+
# if options['provide_traits'] is True:
468+
# print_status("enthought.traits", "matplotlib will provide")
469+
# return True
468470
try:
469471
from enthought import traits
470472
try:
@@ -478,12 +480,16 @@ def check_provide_traits():
478480
version = version.version
479481
except AttributeError:
480482
version = version.__version__
481-
if version.endswith('mpl'):
482-
print_status("enthought.traits", "matplotlib will provide")
483-
return True
484-
else:
485-
print_status("enthought.traits", version)
486-
return False
483+
# next 2 lines added temporarily while we figure out what to do
484+
# with traits:
485+
print_status("enthought.traits", version)
486+
return False
487+
# if version.endswith('mpl'):
488+
# print_status("enthought.traits", "matplotlib will provide")
489+
# return True
490+
# else:
491+
# print_status("enthought.traits", version)
492+
# return False
487493
except ImportError:
488494
if options['provide_traits']:
489495
print_status("enthought.traits", "matplotlib will provide")

0 commit comments

Comments
 (0)