Skip to content

fix: trigger create hubspot user post tracker #5711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: feat/collect-and-track-utms-at-signup
Choose a base branch
from

Conversation

Zaimwa9
Copy link
Contributor

@Zaimwa9 Zaimwa9 commented Jul 4, 2025

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

We need the cookie (and utms) before creating the hubspot contact. As it was deferred to the task processor as a user post_create hook, the creation could happen before storing the relevant data.

This PR moved the dispatch after creating the Hubspot tracker

How did you test this code?

  • Added tests

@Zaimwa9 Zaimwa9 requested review from a team as code owners July 4, 2025 16:31
@Zaimwa9 Zaimwa9 requested review from tiagoapolo and emyller and removed request for a team July 4, 2025 16:31
Copy link

vercel bot commented Jul 4, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Jul 7, 2025 8:44am
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Visit Preview Jul 7, 2025 8:44am
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Visit Preview Jul 7, 2025 8:44am

@Zaimwa9 Zaimwa9 changed the title Fix: trigger create hubspot user post tracker fix: trigger create hubspot user post tracker Jul 4, 2025
@Zaimwa9 Zaimwa9 changed the base branch from main to feat/collect-and-track-utms-at-signup July 4, 2025 16:31
@github-actions github-actions bot added the api Issue related to the REST API label Jul 4, 2025
Copy link
Contributor

github-actions bot commented Jul 4, 2025

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-5711 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-5711 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-5711 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-5711 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-5711 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-5711 Finished ✅ Results

@github-actions github-actions bot added the fix label Jul 7, 2025
@github-actions github-actions bot added fix and removed fix labels Jul 7, 2025
Copy link

codecov bot commented Jul 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.77%. Comparing base (1c23a8d) to head (eac44bb).

Additional details and impacted files
@@                            Coverage Diff                            @@
##           feat/collect-and-track-utms-at-signup    #5711      +/-   ##
=========================================================================
- Coverage                                  97.77%   97.77%   -0.01%     
=========================================================================
  Files                                       1255     1255              
  Lines                                      44317    44324       +7     
=========================================================================
+ Hits                                       43331    43336       +5     
- Misses                                       986      988       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant