Skip to content

Add hash_type to credentials search endpoint #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 20, 2025

Conversation

sebd11
Copy link
Contributor

@sebd11 sebd11 commented Mar 19, 2025

No description provided.

@sebd11 sebd11 requested review from aviau and xvaier March 19, 2025 15:00
@gpratte-flare
Copy link

lgtm.

@aviau
Copy link
Member

aviau commented Mar 19, 2025

Umm, can it actually be null?

@sebd11
Copy link
Contributor Author

sebd11 commented Mar 19, 2025

Umm, can it actually be null?

Yes it can be. it's a nullable field at the database level.

In most cases you will find unknown instead of null, but it's possible to encounter nulls

@sebd11 sebd11 merged commit 83db5ac into main Mar 20, 2025
2 checks passed
@sebd11 sebd11 deleted the sebastien/add-hash-type-to-credentials-search-api branch March 20, 2025 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants