Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opening a popup sometimes scrolls to the bottom automatically #688

Open
cmdcolin opened this issue Feb 15, 2016 · 8 comments
Open

Opening a popup sometimes scrolls to the bottom automatically #688

cmdcolin opened this issue Feb 15, 2016 · 8 comments
Labels
big task this takes a week or more of work bug this is a problem that needs to be fixed

Comments

@cmdcolin
Copy link
Contributor

It was noted that sometimes when opening a popup (in jbrowse...) it will automatically scroll to the bottom. First discussed here http://gmod.827538.n3.nabble.com/Gmod-ajax-JBrowse-Popup-focus-td4053110.html

I had also noticed this for awhile but didn't really know why

I did note however that there is a pretty interesting distinction where if you left-click a feature, then it seems to always scroll to bottom of the popup (the bug) but if you right-click and select "View details" or similar, then it does not seem to scroll to the bottom.

Can't be sure exactly why it happens, but it seems reproducible in some multiple browsers on both phytozome and volvox instances

@cmdcolin
Copy link
Contributor Author

I would say the easiest track to reproduce this on is the BAM tracks, e.g. http://jbrowse.org/code/JBrowse-1.12.0/?data=sample_data/json/volvox&loc=ctgA:24449..34449&tracks=DNA,volvox-paired_bam

Just mentioning because this is sometimes inconsistent

@exogenesys
Copy link
Contributor

Hi, guys.

I was trying to fix this bug for my GSOC project. After closely observing the inconsistency, I realized that the pop-up never is scrolled down the first time. Only after we close the pop-up by clicking on the back drop (anywhere else other than the pop-up) and open it again, then only the pop-up is scrolled to the bottom.

Clicking on the backdrop scrolls the pop-up down before closing. And the next time we open it up, it has already scrolled down.

Closing the pop-up by the close button (the little cross) doesn't scroll the pop-up before closing and it works perfectly then.

Please confirm this for me. What do you guys think?

@rdhayes
Copy link
Contributor

rdhayes commented Mar 7, 2016

I looked again at one of our species with long popup content.

For this example:
https://phytozome.jgi.doe.gov/jbrowse/index.html?data=genomes%2FSbicolor&loc=Chr01%3A25329..27522&tracks=Transcripts%2CAlt_Transcripts%2CBlastx_protein%2CGeneExpression_GeneAtlas1_0%2Cnatgen2014_variation&highlight=

This is still v1.11.6. The "BLASTX Plant Protein" track uses the default
popup. After closing by clicking outside the popup, that will reopen at the
top. I'm seeing the popup close normally by clicking outside it, but using
the upper-right X or "OK" button at the bottom triggers the possibly
related issue where the popup had opened twice (or needs to be closed
twice).

The "Gene Atlas Gene Expression" track uses onclick.content to replace the
default popup, and always opens scrolled to the bottom. Same issue as
above, only closing with one action if I click outside the popup.

The "Patterson (2009) 23 sample variation" track is a VCF track that uses
"onClick.action = xhrDialog" and onclick.url to dynamically populate the
popup. This one always loads at the top, and the X closes with one attempt.

Richard D. Hayes, Ph.D.
Joint Genome Institute / Lawrence Berkeley National Lab
http://phytozome.jgi.doe.gov

On Fri, Mar 4, 2016 at 12:17 AM, Harsh Gautam notifications@github.com
wrote:

Hi, guys.

I was trying to fix this bug for my GSOC project. After closely observing
the inconsistency, I realized that the pop-up never is scrolled down the
first time. Only after we close the pop-up by clicking on the back drop
(anywhere else other than the pop-up) and open it again, then only the
pop-up is scrolled to the bottom.

Clicking on the backdrop scrolls the pop-up down before closing. And the
next time we open it up, it has already scrolled down.

Closing the pop-up by the close button (the little cross) doesn't scroll
the pop-up before closing and it works perfectly then.

Please confirm this for me. What do you guys think?


Reply to this email directly or view it on GitHub
#688 (comment).

@rbuels rbuels added the bug this is a problem that needs to be fixed label Jan 30, 2018
@rbuels
Copy link
Collaborator

rbuels commented Jan 30, 2018

Can anybody confirm whether this bug is still present?

@rdhayes
Copy link
Contributor

rdhayes commented Jan 30, 2018 via email

@rbuels rbuels added the big task this takes a week or more of work label Jul 11, 2018
@ValWood
Copy link

ValWood commented Oct 29, 2022

I don't know if this is the same issue, but in our gene page embedded view the scroll be is always at the bottom, it would be better at the top
examples:
https://www.pombase.org/gene/SPBC27.08c
https://www.pombase.org/gene/SPBC28F2.07
https://www.pombase.org/gene/SPNCRNA.5244

Is this the same issue?
Is there a way to pin to the top of the pane yet?

@cmdcolin
Copy link
Contributor Author

Hi @ValWood unfortunately I don't think we can provide much support for this. We are mostly developing jbrowse 2 now

@cmdcolin
Copy link
Contributor Author

If you find any fixes from your team feel free to update this thread though, it's just likely something we can't investigate ourselves

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
big task this takes a week or more of work bug this is a problem that needs to be fixed
Projects
None yet
Development

No branches or pull requests

5 participants