Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adapt allay-api 0.2.0 #490

Merged
merged 6 commits into from
Mar 6, 2025

Conversation

smartcmd
Copy link
Contributor

@smartcmd smartcmd commented Mar 3, 2025

No description provided.

IWareQ added 2 commits March 3, 2025 16:23
6808d0e](GeyserMC/mappings@6808d0e)
chores: sort je default states and add new
docs: add how to use in README.md
@duplexsystem
Copy link
Member

@IWareQ please do not use var as it is against out current code style. Please also run intellij reformat code so the code matches out code style. Usage docs should not be in the readme file and instead in our docs repo, please contribute the docs there. Even if it is automatically pulled in from another place the GSON dependency should be explicitly defined in the build files.

Also I'd like to re-request that the geyser related data files be version and pulled as part of the build system instead od being in repo. Geyser does this so I know it's easily done. I'd also like if allay set up a repo and package for the file from the wiki so that can be versioned as well.

@IWareQ IWareQ requested a review from astrsh as a code owner March 6, 2025 21:02
@duplexsystem
Copy link
Member

@IWareQ LMK when this is ready for mere :)

@duplexsystem duplexsystem merged commit 1b15694 into PolyhedralDev:master Mar 6, 2025
1 check passed
@smartcmd smartcmd deleted the dev/allay-api-0.2.0 branch March 8, 2025 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants