Revert "Fix invalid comparator in savedata_op sorting"

[Megamouse]

This reverts commit 22d9343.

It seems to have broken some games

[Megamouse]

I'd like to merge this before we get #17330 tested etc.

[elad335]

It's unlkely related to savedata at all, some games in the issue do not call these functions before experiencing the issue. People have commented that it also happens irregardless of pre-existing savedata.

[antoniodesousa]

I just tested the build and it didn't fix the broken audio that's affecting a lot of games.
It's very strange because the previous build to this change doesn't have the issue.
0.0.37-18022 -> Audio works
0.0.37-18023 -> Audio broken

[Lagahan]

#17332 still crashing with this build, gets to the same point in the log:
RPCS3.log

[elad335]

Please test this build for this issue. @antoniodesousa

rpcs3.zip

This is a locally-compiled build of RPCS3.

[antoniodesousa]

Please test this build for this issue. @antoniodesousa
rpcs3.zip
This is a locally-compiled build of RPCS3.

No change. Audio is still broken in Tekken 6, Tekken 5 DR, Time Crisis 4, Demon Souls, Metal Gear 4...

[schm1dtmac]

It's unlkely related to savedata at all, some games in the issue do not call these functions before experiencing the issue. People have commented that it also happens irregardless of pre-existing savedata.

Here’s a mad thought I had: could this simply be a coincidence relating to dependencies? Could be plausible that around when #17322 was merged the RPCS3 Actions builds started compiling with a newer version of some dependency (cubeb, ffmpeg, anything audio-related ig), which could be the root cause of breakage.

[digant73]

if I compile latest rpcs3 version 0.0.37-18056 (on win 11 in my case) the audio is properly working while the same version updated from an official rpcs3 binary, or downloaded from the official site, does not work

[antoniodesousa]

if I compile latest rpcs3 version 0.0.37-18056 (on win 11 in my case) the audio is properly working while the same version updated from an official rpcs3 binary, or downloaded from the official site, does not work

That's very interesting indeed.

[AniLeo]

It could be a newer msvc version introducing a regression, we still don't know what caused the regression, but it's not the code change itself, as it only touches specific savedata code that can't break audio

[AniLeo]

I'll close this one since we pinpointed the root cause being a faulty compiler update and not the PR itself here: #17326 (comment)