Skip to content

format #669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
May 5, 2025
Merged

format #669

merged 8 commits into from
May 5, 2025

Conversation

meiravgri
Copy link
Collaborator

@meiravgri meiravgri commented May 4, 2025 •
edited
Loading

fix format

@meiravgri meiravgri changed the title format (?) format May 4, 2025
@meiravgri meiravgri requested review from alonre24 and GuyAv46 May 4, 2025 14:59
@meiravgri meiravgri enabled auto-merge May 4, 2025 15:00
@codecov Codecov
Copy link

codecov bot commented May 4, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.33%. Comparing base (237041e) to head (e92fc24).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #669   +/-   ##
=======================================
  Coverage   96.33%   96.33%           
=======================================
  Files         112      112           
  Lines        6225     6225           
=======================================
  Hits         5997     5997           
  Misses        228      228

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

GuyAv46
GuyAv46 reviewed May 4, 2025
View reviewed changes
src/VecSim/spaces/computer/preprocessors.h Outdated
@@ -5,7 +5,8 @@
* Licensed under your choice of the Redis Source Available License 2.0
* (RSALv2); or (b) the Server Side Public License v1 (SSPLv1); or (c) the
* GNU Affero General Public License v3 (AGPLv3).
*/#pragma once
*/ \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
*/ \
*/

@meiravgri meiravgri requested a review from GuyAv46 May 5, 2025 03:53
GuyAv46
GuyAv46 reviewed May 5, 2025
View reviewed changes
Copy link
Collaborator

@GuyAv46 GuyAv46 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another two I missed

meiravgri and others added 2 commits May 5, 2025 08:02
@meiravgri @GuyAv46
Update src/VecSim/index_factories/index_factory.h
398c661 
Co-authored-by: GuyAv46 <47632673+GuyAv46@users.noreply.github.com>
@meiravgri @GuyAv46
Update src/VecSim/index_factories/tiered_factory.h
e92fc24 
Co-authored-by: GuyAv46 <47632673+GuyAv46@users.noreply.github.com>
@meiravgri meiravgri requested a review from GuyAv46 May 5, 2025 05:30
@meiravgri meiravgri added this pull request to the merge queue May 5, 2025
Merged via the queue into main with commit 1f26bf1 May 5, 2025
16 of 17 checks passed
@meiravgri meiravgri deleted the meiravg_format branch May 5, 2025 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuyAv46 GuyAv46

@alonre24 alonre24

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@meiravgri @GuyAv46