Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding spellcheck to CI, and fixing docs along the way #933

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

chayim
Copy link
Contributor

@chayim chayim commented Aug 14, 2022

No description provided.

@codecov
Copy link

codecov bot commented Aug 14, 2022

Codecov Report

Merging #933 (13fff15) into master (2dd4ef1) will increase coverage by 0.46%.
The diff coverage is 96.55%.

❗ Current head 13fff15 differs from pull request most recent head 635f727. Consider uploading reports for the commit 635f727 to get more accurate results

@@            Coverage Diff             @@
##           master     #933      +/-   ##
==========================================
+ Coverage   81.30%   81.77%   +0.46%     
==========================================
  Files          54       54              
  Lines        8201     8214      +13     
==========================================
+ Hits         6668     6717      +49     
+ Misses       1533     1497      -36     
Impacted Files Coverage Δ
src/execution/DAG/dag_builder.c 100.00% <ø> (ø)
src/execution/DAG/dag_op.c 100.00% <ø> (ø)
src/execution/parsing/script_commands_parser.c 78.57% <ø> (-0.12%) ⬇️
.../serialization/RDB/decoder/previous/v2/decode_v2.c 46.37% <50.00%> (+0.45%) ⬆️
tests/module/LLAPI.c 75.89% <80.00%> (-0.02%) ⬇️
src/execution/background_workers.c 94.63% <95.23%> (+0.01%) ⬆️
src/redisai.c 89.27% <97.14%> (+1.47%) ⬆️
src/backends/backends.c 78.57% <100.00%> (+0.53%) ⬆️
...backends/libtorch_c/torch_extensions/torch_redis.h 90.90% <100.00%> (ø)
src/backends/tensorflow.c 72.43% <100.00%> (+0.06%) ⬆️
... and 18 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@gkorland
Copy link
Contributor

@chayim

Misspelled words:
<htmlcontent> docs/configuration.md: html>body>p
--------------------------------------------------------------------------------
RedisAI
--------------------------------------------------------------------------------

DvirDukhan
DvirDukhan previously approved these changes Aug 15, 2022
@chayim
Copy link
Contributor Author

chayim commented Aug 16, 2022

@DvirDukhan Sorry, I had to add RedisAI to the wordlist. Mind restamping?

@chayim chayim requested a review from DvirDukhan August 16, 2022 12:31
@DvirDukhan
Copy link
Collaborator

Can you add early return for tests on branches with suffix "spelling" (same as suffix "docs")

@chayim
Copy link
Contributor Author

chayim commented Aug 17, 2022

Done

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants