Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modelset chunk size should be configurable #58

Open
filipecosta90 opened this issue Apr 14, 2021 · 2 comments
Open

modelset chunk size should be configurable #58

filipecosta90 opened this issue Apr 14, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@filipecosta90
Copy link
Contributor

Given https://github.com/redis/redis/blob/unstable/redis.conf#L1854 there might be cases in which we have a Redis instance with a max string size of 1,2,10mb....
The hotfix that added modelset chunking to the client ( https://github.com/RedisAI/redisai-py/pull/35/files ) enforces a chunk size of 512mb. We should address this ( or at least be aware of the limitations/issues that can arise from the current config )

@filipecosta90 filipecosta90 added the bug Something isn't working label Apr 14, 2021
@DvirDukhan
Copy link
Collaborator

@filipecosta90 can we get this value from CONFIG GET command?

@filipecosta90
Copy link
Contributor Author

@filipecosta90 can we get this value from CONFIG GET command?

yes :

127.0.0.1:6379> config get proto-max-bulk-len
1) "proto-max-bulk-len"
2) "536870912"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants