Fix flathub chsrc
#179
Merged
Fix flathub chsrc
#179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
ccmywish
requested changes
Mar 17, 2025
src/framework/mirror.c
Outdated
There was a problem hiding this comment.
这个文件的变动似乎是添加了 Sjtug_Siyuan 这个镜像站，但是可能是你的编辑器或者其他操作使得 GitHub 显示对这个文件进行了巨大的更改，以致于无法看清你的修改。
所以能否重新删除这次 commit 重新提交一次，保持 diff 的清晰？
| * ------------------------------------------------------------*/ | ||
|
|
||
| /** | ||
| * @update 2023-09-11 | ||
| * @note 目前只有一个源 | ||
| * @update 2025-03-17 |
There was a problem hiding this comment.
这个 @update 表示的是源的最后更新时间，只需要把 2023 那个时间覆盖掉即可。
@note 可以把之前的删掉
src/recipe/ware/Flathub.c
Outdated
|
|
||
|
|
||
| /** | ||
| * @consult https://mirrors.sjtug.sjtu.edu.cn/docs/flathub | ||
| */ | ||
| static MirrorSite_t UpstreamFlathub = |
There was a problem hiding this comment.
按照我们之前的命名惯例（可参考 Java.c，Ruby.c），这里应该叫做 wr_flathub_upstream。
结构体是 SourceProvider_t
src/recipe/ware/Flathub.c
Outdated
| {NotSkip, NA, NA, "https://flathub.org/repo/flathub.gpg"} | ||
| }, | ||
|
|
||
| Sjtug_Siyuan_Flathub = |
There was a problem hiding this comment.
我理解的是，你通过额外定义两个“虚拟”的镜像站，目的是为了检测 /flathub/flathub.gpg 这个文件能不能访问到，访问到的测速就不为0，就能被选中？
There was a problem hiding this comment.
是的，检测/flathub/flathub.gpg可能存在502的情况，此时需要跳过。
src/recipe/ware/Flathub.c
Outdated
| @@ -34,6 +58,13 @@ wr_flathub_setsrc (char *option) | |||
| ); | |||
| puts (note); | |||
|
|
|||
| char *repo_note = xy_strjoin (1, | |||
There was a problem hiding this comment.
xy_strjoin(n) 是用于字符串拼接的。这个地方显然不需要拼接，直接用双引号字符串即可
Closed
This reverts commit c38dcd5.
|
最后分别在： 这三个地方加上你的贡献信息即可 👍 |
|
感谢你的贡献，辛苦了 ❤️ Happy changing source~ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
描述
问题的背景
Flathub上海交通大学镜像站存在不兼容的问题相关 issue
这个PR做了什么
Ware Flathub换源mirror.c中区分了上海交通大学思源镜像站和致远镜像站方案
实现
Flathub.c中用于测试的MirrorSite_t和对应的测试链接测试