Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add e2e tests for the new types in the metadata and improvements #1779

Merged
merged 82 commits into from
Mar 26, 2025

Conversation

martin-trajanovski
Copy link
Collaborator

@martin-trajanovski martin-trajanovski commented Mar 5, 2025

Description

Adds end-to-end tests for metadata types and some small improvements

Motivation

The new added types in the metadata were not tested

Fixes:

Changes:

  • Adds e2e tests for 'date', 'link', 'number_range', and 'quantity_range' metadata types.

Tests included

  • Included for each change/fix?
  • Passing? (Merge will not be approved unless this is checked)

Documentation

  • swagger documentation updated [required]
  • official documentation updated [nice-to-have]

official documentation info

If you have updated the official documentation, please provide PR # and URL of the pages where the updates are included

Backend version

  • Does it require a specific version of the backend
  • which version of the backend is required:

Summary by Sourcery

Adds end-to-end tests for metadata types and some small improvements

Tests:

  • Adds e2e tests for 'date', 'link', 'number_range', and 'quantity_range' metadata types.

Summary by Sourcery

Tests:

  • Adds e2e tests for 'date', 'link', 'number_range', and 'quantity_range' metadata types.

martin-trajanovski and others added 30 commits January 13, 2025 16:29
@martin-trajanovski martin-trajanovski marked this pull request as ready for review March 24, 2025 07:12
@martin-trajanovski martin-trajanovski added DCS DAPHNE Contribution to SciCat testing labels Mar 24, 2025
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @martin-trajanovski - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider adding a custom command to reduce the amount of repeated code in the tests.
  • It might be useful to add a comment explaining why the createDataset command is being modified.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟡 Complexity: 1 issue found
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@martin-trajanovski martin-trajanovski merged commit 54257be into master Mar 26, 2025
10 of 11 checks passed
@martin-trajanovski martin-trajanovski deleted the SWAP-4565-add-metadata-improvements-e2e branch March 26, 2025 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DCS DAPHNE Contribution to SciCat testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants