-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add e2e tests for the new types in the metadata and improvements #1779
Merged
martin-trajanovski
merged 82 commits into
master
from
SWAP-4565-add-metadata-improvements-e2e
Mar 26, 2025
Merged
test: add e2e tests for the new types in the metadata and improvements #1779
martin-trajanovski
merged 82 commits into
master
from
SWAP-4565-add-metadata-improvements-e2e
Mar 26, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tProject/frontend into add-dynamic-material-table
…' of https://github.com/SciCatProject/frontend into SWAP-4456-dataset-metadata-improvements
…hub.com/SciCatProject/frontend into SWAP-4456-dataset-metadata-improvements
…to SWAP-4564-add-range-metadata-types
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @martin-trajanovski - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a custom command to reduce the amount of repeated code in the tests.
- It might be useful to add a comment explaining why the createDataset command is being modified.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟡 Complexity: 1 issue found
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Junjiequan
approved these changes
Mar 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds end-to-end tests for metadata types and some small improvements
Motivation
The new added types in the metadata were not tested
Fixes:
Changes:
Tests included
Documentation
official documentation info
If you have updated the official documentation, please provide PR # and URL of the pages where the updates are included
Backend version
Summary by Sourcery
Adds end-to-end tests for metadata types and some small improvements
Tests:
Summary by Sourcery
Tests: