Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SPE exceptional access pattern for SPE copilot #10185

Merged

Conversation

dluces
Copy link
Contributor

@dluces dluces commented Apr 4, 2025

Category

  • Content fix
  • New article

Related issues

  • fixes n/a
  • partially n/a
  • mentioned in n/a

What's in this Pull Request?

Mention the exceptional access pattern required for the SharePoint Embedded copilot experience.

Copy link
Contributor

Learn Build status updates of commit 728f199:

✅ Validation status: passed

File Status Preview URL Details
docs/embedded/development/auth.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@gnjoseph
Copy link
Contributor

gnjoseph commented Apr 7, 2025

@andrewconnell @cindylay can you review please.

@andrewconnell andrewconnell self-assigned this Apr 7, 2025
@andrewconnell
Copy link
Collaborator

@gnjoseph No need to @mention me... all PRs are reviewed on a weekly basis. To request my review, use the built-in feature in GH PRs.

@andrewconnell andrewconnell requested a review from cindylay April 8, 2025 12:09
@andrewconnell
Copy link
Collaborator

andrewconnell commented Apr 8, 2025

@cindylay I've noticed over the last month or 2, a lot more people have been submitting changes to the SPE docs. However, I can't tell from their GH handles who they are... are they Microsoft employees or a customer, are they on the SPE team and have the authority to edit the official docs, etc (like this PR for example).

For small typos/fixes (grammar, markdown formatting, etc), this isn't an issue because it doesn't change the official docs. But for other changes, I need someone from Microsoft (ie: you 😉) to submit your own review & ok it. I'll still review them, but these changes won't be merged until I get your (or someone on the SPE team I recognize) approval.

Make sense? Any questions?

This PR is fine... I recognize @dluces from the SPE PG... but others... that's where I need someone from the SPE team to give their OK on the docs change.

@andrewconnell andrewconnell requested review from andrewconnell and removed request for cindylay April 8, 2025 12:10
@cindylay
Copy link
Contributor

cindylay commented Apr 9, 2025

These changes look correct to me, ready to merge.

@cindylay cindylay self-requested a review April 9, 2025 06:21
@andrewconnell andrewconnell added the pr:in-review Actively reviewing pull request label Apr 9, 2025
@andrewconnell
Copy link
Collaborator

@cindylay said

These changes look correct to me, ready to merge.

Thanks... would you mind doing the review & approving it for tracking in the PR checklist vs. adding a comment? You can see this in the PR checklist:

Screenshot 2025-04-09 at 8 20 54 AM

... I requested you to review (Reviews top-right in the web UX)...

Screenshot 2025-04-09 at 8 20 33 AM

You can see two people have done their reviews... you and I are the pending ones in the screenshot above.

At the top of the PR there's a notification and button for you to do your review...

Screenshot 2025-04-09 at 8 21 47 AM

You can approve the PR and close your review, add comments, request changes, etc...

Screenshot 2025-04-09 at 8 22 45 AM

Once you select APPROVE & select SUBMIT REVIEW in the last screenshot, that shows your approval. That's what I'll look for instead of scanning comments which can be tedious for long PRs.

Copy link
Contributor

Learn Build status updates of commit 9e7bfea:

✅ Validation status: passed

File Status Preview URL Details
docs/embedded/development/auth.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@cindylay
Copy link
Contributor

cindylay commented Apr 9, 2025

Got it, thank you!! For some reason the review button didn't show up for me in the GitHub UI until just now. Will use that for the future

@andrewconnell andrewconnell added pr:ready-to-merge Ready to merge PR and removed pr:in-review Actively reviewing pull request labels Apr 9, 2025
@andrewconnell andrewconnell merged commit eab1cba into SharePoint:main Apr 9, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:ready-to-merge Ready to merge PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants