-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SPE exceptional access pattern for SPE copilot #10185
Add SPE exceptional access pattern for SPE copilot #10185
Conversation
Learn Build status updates of commit 728f199: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
@andrewconnell @cindylay can you review please. |
@gnjoseph No need to @mention me... all PRs are reviewed on a weekly basis. To request my review, use the built-in feature in GH PRs. |
@cindylay I've noticed over the last month or 2, a lot more people have been submitting changes to the SPE docs. However, I can't tell from their GH handles who they are... are they Microsoft employees or a customer, are they on the SPE team and have the authority to edit the official docs, etc (like this PR for example). For small typos/fixes (grammar, markdown formatting, etc), this isn't an issue because it doesn't change the official docs. But for other changes, I need someone from Microsoft (ie: you 😉) to submit your own review & ok it. I'll still review them, but these changes won't be merged until I get your (or someone on the SPE team I recognize) approval. Make sense? Any questions? This PR is fine... I recognize @dluces from the SPE PG... but others... that's where I need someone from the SPE team to give their OK on the docs change. |
These changes look correct to me, ready to merge. |
@cindylay said
Thanks... would you mind doing the review & approving it for tracking in the PR checklist vs. adding a comment? You can see this in the PR checklist: ![]() ... I requested you to review (Reviews top-right in the web UX)... ![]() You can see two people have done their reviews... you and I are the pending ones in the screenshot above. At the top of the PR there's a notification and button for you to do your review... ![]() You can approve the PR and close your review, add comments, request changes, etc... ![]() Once you select APPROVE & select SUBMIT REVIEW in the last screenshot, that shows your approval. That's what I'll look for instead of scanning comments which can be tedious for long PRs. |
Learn Build status updates of commit 9e7bfea: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Got it, thank you!! For some reason the review button didn't show up for me in the GitHub UI until just now. Will use that for the future |
Category
Related issues
What's in this Pull Request?
Mention the exceptional access pattern required for the SharePoint Embedded copilot experience.