Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: drop support for PHP 5.6 and move to at least 7.2 #55

Open
madman-81 opened this issue May 9, 2019 · 5 comments
Open

Proposal: drop support for PHP 5.6 and move to at least 7.2 #55

madman-81 opened this issue May 9, 2019 · 5 comments

Comments

@madman-81
Copy link

Since PHP support for 5.6 has stopped long ago and even version 7.1 only has security support (until December 1st), I would like to propose to set the required PHP version to >=7.2. This would, allow for some clean up of code, enable more type hinting, etc.

Please let me know if other people would like move forward too or if there are any reasons why not to do this.

@madman-81
Copy link
Author

@Torann Would be nice to have your input on this. If you agree, I could also add a pull request for this if you like to.

@Torann
Copy link
Owner

Torann commented May 15, 2019

Sounds great to me

@madman-81
Copy link
Author

Great, I'll start working on that soon then! Since this could result in quite some changes, it would be convenient if the other pull requests are reviewed and merged before starting on this one. This makes things a bit easier with less merge conflicts. Could you have a look at them?

@Torann
Copy link
Owner

Torann commented Mar 10, 2020

I'll look into doing this for the next release and make it the official v1.0 release

@Torann
Copy link
Owner

Torann commented Mar 10, 2020

Just started 1.0.0 🎆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants