Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: [NGOv1.X] Corrections of CI setup issues #3326

Merged
merged 58 commits into from
Mar 21, 2025

Conversation

michalChrobot
Copy link
Collaborator

@michalChrobot michalChrobot commented Feb 27, 2025

This PR focuses on fixing CI issues raised in #3303 and before. Specifically:

  1. 2023.3 editor was removed from supported list since based on official info it transitioned into 6000 editor and 2023 editor (by itself) is not supported. The associated ticket was (MTT-11355)
  2. In case of ubuntu and 2021 editor (MTT-11354) correct version of libssl is being installed
  3. UTR command was corrected to use preinstalled UTR on the image instead of downloading it
  4. Removed upm-ci project pack definition and converted Code Coverage test to use upm-pvp pack job
  5. Simplifies some unnecessary CI commands
  6. Added detailed comments regarding CI setup and commands
  7. Created CI_README file which describes overall configuration structure.
  8. For macOS devices we now use M1 model (Apple Silicon) in contrast to default x64 Intel Mac which introduced a lot of bit-flipping errors

@michalChrobot michalChrobot self-assigned this Feb 27, 2025
@michalChrobot michalChrobot changed the title ci: Fixes for CI issues ci: [NGOv1.X] Corrections of CI setup issues Mar 3, 2025
@michalChrobot michalChrobot requested review from fluong6, EmandM and a team as code owners March 12, 2025 12:17
Copy link
Collaborator

@EmandM EmandM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fantastic! Just a final point. If you name the markdown file README.md rather than CI_README.md, github will show the README when you view the folder.

@michalChrobot michalChrobot requested a review from EmandM March 18, 2025 08:41
@michalChrobot
Copy link
Collaborator Author

Hey @EmandM @NoelStephensUnity, can I get your approval on this PR 😁? It's corresponding to #3329 so you can check/approve both and then I can proceed

@michalChrobot michalChrobot merged commit 12dd5bd into develop Mar 21, 2025
40 checks passed
@michalChrobot michalChrobot deleted the fixing-disabled-tests-round1 branch March 21, 2025 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants