Design review for new DFW API #6
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Constructor takes the serial port number, but in the comments it notes that Serial1 is the only valid one. THis has been changed to only access Serial1 and removed the parameter.
The competition code is being switched over to a function pointer model.
The functions that the user defines, now include the passing of the DFW object from the fundtion call to the user function. THe lets the user functions to be in isolated files and avoids code clutter. It also provides an example to the users of how to pass objects around between sections of code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
THe API for the DFW competition code is updated and ready for a design review.