Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync Codepage Settings on Options and Diff Window #2678

Closed
bohni opened this issue Mar 17, 2025 · 3 comments
Closed

Sync Codepage Settings on Options and Diff Window #2678

bohni opened this issue Mar 17, 2025 · 3 comments
Milestone

Comments

@bohni
Copy link

bohni commented Mar 17, 2025

The Codepage Selection in Options and Diff-Window are different

E.g. Diff-Window is missing Codepage 850 - and shows other numbers

Image

Image

Options > Codepage:

Image

@sdottaka
Copy link
Member

This issue has been fixed in commit 6a141a9. Thank you for your report.

@sdottaka sdottaka added this to the v2.16.47 milestone Mar 17, 2025
@bohni
Copy link
Author

bohni commented Mar 17, 2025

Thanks for the fast fix!

Don't you think, the duplicate code should be moved to

std::vector<CodePageInfo> enumCodePages()
?

@sdottaka
Copy link
Member

Duplicate code is not good, but I would like to avoid modifying enumCodePages() at the very least because it would be an incomplete fix. If I were to modify it, I would create a separate function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants