Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tree traversal: Julia implementation deprecated #841

Closed
4 tasks done
stormofice opened this issue Aug 23, 2021 · 0 comments · Fixed by #842
Closed
4 tasks done

Tree traversal: Julia implementation deprecated #841

stormofice opened this issue Aug 23, 2021 · 0 comments · Fixed by #842
Labels
Problem This is a problem in the archive or an implementation.

Comments

@stormofice
Copy link
Contributor

stormofice commented Aug 23, 2021

Bug Report

Description

The Julia implementation of the tree traversal chapter relies upon the DataCollections.jl package.
Since version v0.17.7 front() and top() were deprecated or removed entirely resulting in the example not working if you have the newest (default) version installed.

Error:

┌ Warning: `top` is deprecated, use `first` instead.
│   caller = DFS_stack(::Node) at Tree.jl:50
└ @ Main ~/algorithm-archive/contents/tree_traversal/code/julia/Tree.jl:50
ERROR: LoadError: UndefVarError: front not defined

Steps to Reproduce

Steps to reproduce the behavior:

  1. Install Julia and the Data Structures package (with version >= 0.17.7, newest is the default)
  2. Try to run the example
  3. See error

Expected behavior

The example working without explicitly using an older package version.
Will be fixed by #842.

Environment

  • OS: Ubuntu
  • OS Version: 20.04
  • Julia Version: 1.4.1

Additional context

This can be easily fixed by changing front() and top() to first().

For Algorithm Archive Developers

  • The bug can be reproduced
  • The bug can be fixed (if not, please explain why not in a comment below)
  • There is a timeline to fix the bug
  • The bug has been fixed (Please link the PR)
@stormofice stormofice added the Problem This is a problem in the archive or an implementation. label Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Problem This is a problem in the archive or an implementation.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant