Skip to content

Suggestion: Add github CLI inside Docker #970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ShadowMitia opened this issue Dec 5, 2021 · 3 comments
Closed

Suggestion: Add github CLI inside Docker #970

ShadowMitia opened this issue Dec 5, 2021 · 3 comments
Assignees
Labels
Discussion This is open for a discussion.

Comments

@ShadowMitia
Copy link
Contributor

I was thinking we could maybe add the Github CLI tool, not particular reason other than have it as a commodity for people using Docker.

It would make testing PRs a bit easier, because you can just go and grab the command directly from Github:

image

I don't really use the tool for anything else myself, but maybe there are other uses to simplify git/github interaction?

@ShadowMitia ShadowMitia added the Discussion This is open for a discussion. label Dec 5, 2021
@ShadowMitia ShadowMitia self-assigned this Dec 5, 2021
@Amaras
Copy link
Member

Amaras commented Dec 5, 2021

I use the official CLI myself (outside of Docker containers), and I can tell you that it's way easier to switch between PRs.

However, if we modify the Docker configuration, it requires to build the image locally, and I don't think there is an extension to do that. (EDIT: Not useful)

@ShadowMitia
Copy link
Contributor Author

As pointed out by @Amaras on Discord, gh requires authentication/token to allow to be used correctly. Even with the gh pr one, which is annoying... Still could be useful, but much less practical right now.

@Amaras
Copy link
Member

Amaras commented Apr 21, 2022

Closing this for now

@Amaras Amaras closed this as completed Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Discussion This is open for a discussion.
Projects
None yet
Development

No branches or pull requests

2 participants