Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Java compilation #973

Merged
merged 5 commits into from
Dec 21, 2021
Merged

Added Java compilation #973

merged 5 commits into from
Dec 21, 2021

Conversation

Amaras
Copy link
Member

@Amaras Amaras commented Dec 5, 2021

This is the PR to close #972.

For now, I have implemented compilation with .class files.
We might want to use .jar files instead, but they require a manifest file.

It it also possible since Java 11 to simply run a single file, so a copier could be enough (assuming Java 11+).


Verified

This commit was signed with the committer’s verified signature.
Amaras Sammy Plat

Verified

This commit was signed with the committer’s verified signature.
Amaras Sammy Plat

Verified

This commit was signed with the committer’s verified signature.
Amaras Sammy Plat
@Amaras Amaras mentioned this pull request Dec 8, 2021
@Amaras Amaras added the SCons For SCons-related matters label Dec 19, 2021

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Copy link
Member

@leios leios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotta be honest, I don't know Java super well, but I trust this

Verified

This commit was signed with the committer’s verified signature.
Amaras Sammy Plat
@Amaras
Copy link
Member Author

Amaras commented Dec 21, 2021

Alright, I guess I will merge this PR, it has been open long enough for people to criticize, and no disagreement came of it.
If you have any qualms, please open a PR in response to correct this.
The GH Actions run correctly, so I don't think there will be a problem with it, though (the changed filenames were fixed)

@Amaras Amaras merged commit 62f2a31 into algorithm-archivists:main Dec 21, 2021
@Amaras Amaras deleted the java_scons branch December 21, 2021 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SCons For SCons-related matters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Java
2 participants