Skip to content
This repository was archived by the owner on May 12, 2021. It is now read-only.

dynamic Dimensions #5

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Conversation

muzhongjiang
Copy link

No description provided.

Copy link
Contributor

@dszeto dszeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

this()
this.attrs = attrs
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @MZJgithub , wondering why we need to have an auxiliary constructor here. Can we simply have

class Query(val attrs: Seq[Double]) extends Serializable

?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants