Parking Lot Thread Fix #140
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ParkingLot Concurrency changes
Remove Synchronized from parkVehicle and unparkVehicle as it is not required
ParkingSpot has been modified to be thread safe.
Clients need not lock exclusively.
Number of floors wont change after construction. so no need for synchrnoziation there.
Changed concurrentHashMap to HashMap
there are no iterations happening on map, or there is no putIfAbsent kind of operations
hence use of concurrentHashMap is not needed.
https://stackoverflow.com/questions/1378310/performance-concurrenthashmap-vs-hashmap
Note: I am prepping for interviews, and i am reading JCIP, trying to implement the concepts here.