Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the main script to fix issue #19 #23

Merged
merged 5 commits into from
Sep 13, 2020
Merged

Adding the main script to fix issue #19 #23

merged 5 commits into from
Sep 13, 2020

Conversation

abirbhattacharya82
Copy link
Contributor

Description

Since I saw there was an issue which stated that they required a Calculator which has to made using Tkinter and GUI Toolkits, I decided to take up this topic

Related Issues or Pull Requests

#19

Have you read the Contributing Guidelines on Pull Requests?

  • Yes
  • No

Checklist

  • I've read the contribution guidelines.
  • I've checked the issue list before deciding what to submit.
  • I've edited the README.md and link to my code.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations!! for making your first PR at Amazing-Python-Scripts, our mentors will review it soon.

@avinashkranjan avinashkranjan linked an issue Sep 12, 2020 that may be closed by this pull request
@avinashkranjan avinashkranjan self-requested a review September 12, 2020 11:01
Copy link
Owner

@avinashkranjan avinashkranjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abirbhattacharya82 The calculator is very small. Kindly make the buttions a little bigger..and If you don't plan to use maximize function..Kindly disable it and update the script in the ReadMe Scripts Available table.
Rest LGTM..

Copy link
Contributor Author

@abirbhattacharya82 abirbhattacharya82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Buttons Made Larger

Copy link
Contributor Author

@abirbhattacharya82 abirbhattacharya82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Buttons made Larger
  • Maximize button is disabled

Copy link
Owner

@avinashkranjan avinashkranjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Calculator is not able to take multiple equations
Say, 20+30*60 .. Look in that.. Try exploring Eval function..
Make Clear Button Size Uniform with the the digits button size..It looks odd..

@abirbhattacharya82
Copy link
Contributor Author

If I make the clear button bigger like the other button then it will be odd because I kept its height same as the height of the adjacent textbox. And a textbox height cannot be altered. However if you still want the size of the Clear button to be it can be done. And speaking of multiple equations I am working on it.

Copy link
Contributor Author

@abirbhattacharya82 abirbhattacharya82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Clear button is made comparitively Larger than before keeping it in parity with the height of the Text Box. Also supports Multiple calculation like a Standard Calculator.

Copy link
Owner

@avinashkranjan avinashkranjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great...LGTM 💯

@avinashkranjan avinashkranjan merged commit eaa7be5 into avinashkranjan:master Sep 13, 2020
@avinashkranjan
Copy link
Owner

@all-contributors please add @abirbhattacharya82 for code

@allcontributors
Copy link
Contributor

@avinashkranjan

I've put up a pull request to add @abirbhattacharya82! 🎉

@abirbhattacharya82 abirbhattacharya82 deleted the patch-2 branch September 13, 2020 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Making Graphical Calculator using Tkinter (GUI)
2 participants