Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bmi-calculator added #48

Merged
merged 1 commit into from
Oct 1, 2020
Merged

bmi-calculator added #48

merged 1 commit into from
Oct 1, 2020

Conversation

shivamsh555
Copy link
Contributor

this is my first PR pls help me to support open source by adding this to your repo. thank you

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations!! for making your first PR at Amazing-Python-Scripts, our mentors will review it soon.

@avinashkranjan
Copy link
Owner

@shivamsh555 Kindly, Create a Issue Before Making a PR..Create a Issue for the PR... So I can close the PR linking to the PR...

@avinashkranjan avinashkranjan linked an issue Oct 1, 2020 that may be closed by this pull request
@avinashkranjan avinashkranjan self-requested a review October 1, 2020 11:58
Copy link
Owner

@avinashkranjan avinashkranjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@avinashkranjan avinashkranjan merged commit 428cc8a into avinashkranjan:master Oct 1, 2020
@avinashkranjan
Copy link
Owner

@all-contributors please add @shivamsh555 for code

@allcontributors
Copy link
Contributor

@avinashkranjan

I've put up a pull request to add @shivamsh555! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

bmi-calculator-added
2 participants