Skip to content

New step-functions-workflows-collection - bedrock-evaluations Initial commit #397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

rohanmeh
Copy link
Contributor

Issue #, if available:

Description of changes:
New workflow for orchestrating multiple Bedrock evaluations.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor

@bfreiberg bfreiberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still facing the following error:

Deployment failed with:

Resource handler returned message: "Invalid request provided: CreateCollectionRequest(Description=Collection for vector search, Name=vector-search-collection, Tags=[Tag(Key=aws:cloudformation:stack-name, Value=bedrock-eval), Tag(Key=aws:cloudformation:logical-id, Value=OpenSearchCollection), Tag(Key=aws:cloudformation:stack-id, Value=arn:aws:cloudformation:eu-central-1:914766352016:stack/bedrock-eval/9f3638b0-e9e8-11ef-a14d-0a8c9768cfb5)], Type=VECTORSEARCH), No matching security policy of encryption type found for collection name: vector-search-collection. Please create security policy of encryption type for this collection. (Service: OpenSearchServerless, Status Code: 400, Request ID: 6ddb9760-e4e9-4e69-9e17-92e0e43ac569)" (RequestToken: 0519a234-9d90-a4be-458a-085ad0ead078, HandlerErrorCode: InvalidRequest)

@bfreiberg
Copy link
Contributor

Please also note that there a few comments still unresolved in bedrock-evaluations.json

rohanmeh and others added 4 commits February 17, 2025 12:56
Co-authored-by: Ben <9841563+bfreiberg@users.noreply.github.com>
Co-authored-by: Ben <9841563+bfreiberg@users.noreply.github.com>
@rohanmeh
Copy link
Contributor Author

I'm still facing the following error:

Deployment failed with:
Resource handler returned message: "Invalid request provided: CreateCollectionRequest(Description=Collection for vector search, Name=vector-search-collection, Tags=[Tag(Key=aws:cloudformation:stack-name, Value=bedrock-eval), Tag(Key=aws:cloudformation:logical-id, Value=OpenSearchCollection), Tag(Key=aws:cloudformation:stack-id, Value=arn:aws:cloudformation:eu-central-1:914766352016:stack/bedrock-eval/9f3638b0-e9e8-11ef-a14d-0a8c9768cfb5)], Type=VECTORSEARCH), No matching security policy of encryption type found for collection name: vector-search-collection. Please create security policy of encryption type for this collection. (Service: OpenSearchServerless, Status Code: 400, Request ID: 6ddb9760-e4e9-4e69-9e17-92e0e43ac569)" (RequestToken: 0519a234-9d90-a4be-458a-085ad0ead078, HandlerErrorCode: InvalidRequest)

Apologies. I added a DependsOn line to the Opensearch Collection for the security policies to be created prior to the collection.

@rohanmeh
Copy link
Contributor Author

Json file: Had previously updated the bucket names but forgot to resolve comments. Removed specific region mentions.

Updated readme with suggested changes.

@bfreiberg
Copy link
Contributor

Looks good, thank you for your contribution. Your workflow will be added soon to Serverlessland.com

@julianwood julianwood merged commit 6cae457 into aws-samples:main Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants