[MERGE #641] xplat: build lib/Runtime/Language, lib/Runtime/Math

Merge pull request #641 from jianchun:lang
Notable changes:
- InterpreterStackFrame.cpp: refactor code to get rid of a "goto", which
  was illegal as it skipped other variable initialization.
- TaggedInt.cpp: replaced __try/__except with explict test to deal with a
  floating point exception case.
- JavascriptMath.cpp: "and", "or" are reserved keywords and not allowed
  for variable names.
- pal_mstypes.h: LARGE_INTEGER should have an unnamed union member.

To be addressed:
- implement _ultow_s, _ui64tow_s
- design/implement xplat stack walker (RtlVirtualUnwind, ...)
- Simd only partially builds. The rest needs lots of functions declared in
  emmintrin.h/xmmintrin.h. But PAL conflicts with it. We have been copying
  some functions by hand into palrt.h, but that seems not maintainable.

Author: Jianchun Xu

lib/Common/CommonPal.h

@@ -31,7 +31,6 @@ typedef wchar_t char16;
 #else // !_WIN32
 
 #define USING_PAL_STDLIB 1
-
 #include "inc/pal.h"
 #include "inc/rt/palrt.h"
 #include "inc/rt/no_sal2.h"
@@ -296,8 +295,9 @@ BOOL WINAPI GetModuleHandleEx(
 // and then use the stack size to calculate the stack base
 int GetCurrentThreadStackBounds(char** stackBase, char** stackEnd);
 
-// xplat-todo: cryptographically secure PRNG?
 errno_t rand_s(unsigned int* randomValue);
+errno_t __cdecl _ultow_s(unsigned _Value, WCHAR *_Dst, size_t _SizeInWords, int _Radix);
+errno_t __cdecl _ui64tow_s(unsigned __int64 _Value, WCHAR *_Dst, size_t _SizeInWords, int _Radix);
 
 #define MAXUINT32   ((uint32_t)~((uint32_t)0))
 #define MAXINT32    ((int32_t)(MAXUINT32 >> 1))
@@ -337,6 +337,13 @@ errno_t rand_s(unsigned int* randomValue);
 #define _NOEXCEPT_ noexcept
 #endif
 
+#ifdef _MSC_VER
+extern "C" PVOID _ReturnAddress(VOID);
+#pragma intrinsic(_ReturnAddress)
+#else
+#define _ReturnAddress() __builtin_return_address(0)
+#endif
+
 // xplat-todo: can we get rid of this for clang?
 // Including xmmintrin.h right now creates a ton of
 // compile errors, so temporarily defining this for clang

lib/Common/Memory/RecyclerFastAllocator.h

@@ -49,7 +49,7 @@ class RecyclerFastAllocator
 #endif
         size_t sizeCat = GetAlignedAllocSize();
         Assert(HeapInfo::IsSmallObject(sizeCat));
-        char * memBlock = allocator.InlinedAlloc<(ObjectInfoBits)(attributes & InternalObjectInfoBitMask)>(recycler, sizeCat);
+        char * memBlock = allocator.template InlinedAlloc<(ObjectInfoBits)(attributes & InternalObjectInfoBitMask)>(recycler, sizeCat);
 
         if (memBlock == nullptr)
         {

lib/Runtime/Base/CMakeLists.txt

@@ -1,6 +1,3 @@
-# xplat-todo: This is a skeleton make file and not used in build yet.
-# Please add this to build and fix issues.
-
 add_library (Chakra.Runtime.Base
     CallInfo.cpp
     CharStringCache.cpp

lib/Runtime/Base/ScriptContext.h

@@ -741,8 +741,8 @@ namespace Js
 #ifdef ENABLE_GLOBALIZATION
         TIME_ZONE_INFORMATION timeZoneInfo;
         uint lastTimeZoneUpdateTickCount;
-        DaylightTimeHelper daylightTimeHelper;
 #endif // ENABLE_GLOBALIZATION
+        DaylightTimeHelper daylightTimeHelper;
 
         HostScriptContext * hostScriptContext;
         HaltCallback* scriptEngineHaltCallback;
@@ -860,9 +860,7 @@ namespace Js
         bool isRootTrackerScriptContext;
 #endif
 
-#ifdef ENABLE_GLOBALIZATION
         DaylightTimeHelper *GetDaylightTimeHelper() { return &daylightTimeHelper; }
-#endif // ENABLE_GLOBALIZATION
 
         bool IsClosed() const { return isClosed; }
         bool IsActuallyClosed() const { return isScriptContextActuallyClosed; }

lib/Runtime/ByteCode/CMakeLists.txt

@@ -1,6 +1,3 @@
-# xplat-todo: This is a skeleton make file and not used in build yet.
-# Please add this to build and fix issues.
-
 add_library (Chakra.Runtime.ByteCode
     AsmJsByteCodeDumper.cpp
     AsmJsByteCodeWriter.cpp

lib/Runtime/CMakeLists.txt

@@ -10,3 +10,5 @@ include_directories(
 
 add_subdirectory (Base)
 add_subdirectory (ByteCode)
+add_subdirectory (Language)
+add_subdirectory (Math)

lib/Runtime/Language/CMakeLists.txt

@@ -1,6 +1,3 @@
-# xplat-todo: This is a skeleton make file and not used in build yet.
-# Please add this to build and fix issues.
-
 add_library (Chakra.Runtime.Language
     AsmJs.cpp
     AsmJsByteCodeGenerator.cpp
@@ -31,39 +28,43 @@ add_library (Chakra.Runtime.Language
     ReadOnlyDynamicProfileInfo.cpp
     RuntimeLanguagePch.cpp
     SimdBool16x8Operation.cpp
-    SimdBool16x8OperationX86X64.cpp
+    # SimdBool16x8OperationX86X64.cpp
     SimdBool32x4Operation.cpp
-    SimdBool32x4OperationX86X64.cpp
+    # SimdBool32x4OperationX86X64.cpp
     SimdBool8x16Operation.cpp
-    SimdBool8x16OperationX86X64.cpp
+    # SimdBool8x16OperationX86X64.cpp
     SimdFloat32x4Operation.cpp
-    SimdFloat32x4OperationX86X64.cpp
+    # SimdFloat32x4OperationX86X64.cpp
     SimdFloat64x2Operation.cpp
-    SimdFloat64x2OperationX86X64.cpp
+    # SimdFloat64x2OperationX86X64.cpp
     SimdInt16x8Operation.cpp
-    SimdInt16x8OperationX86X64.cpp
+    # SimdInt16x8OperationX86X64.cpp
     SimdInt32x4Operation.cpp
-    SimdInt32x4OperationX86X64.cpp
+    # SimdInt32x4OperationX86X64.cpp
     SimdInt8x16Operation.cpp
-    SimdInt8x16OperationX86X64.cpp
+    # SimdInt8x16OperationX86X64.cpp
     SimdUint16x8Operation.cpp
-    SimdUint16x8OperationX86X64.cpp
+    # SimdUint16x8OperationX86X64.cpp
     SimdUint32x4Operation.cpp
-    SimdUint32x4OperationX86X64.cpp
+    # SimdUint32x4OperationX86X64.cpp
     SimdUint8x16Operation.cpp
-    SimdUint8x16OperationX86X64.cpp
-    SimdUtils.cpp
+    # SimdUint8x16OperationX86X64.cpp
+    # SimdUtils.cpp
     SourceDynamicProfileManager.cpp
     SourceTextModuleRecord.cpp
     StackTraceArguments.cpp
     TaggedInt.cpp
     ValueType.cpp
-    amd64\AsmJsJitTemplate.cpp
-    amd64\StackFrame.cpp
-    arm64\StackFrame.cpp
-    arm\StackFrame.cpp
-    i386\AsmJsJitTemplate.cpp
-    i386\StackFrame.cpp
+    amd64/AsmJsJitTemplate.cpp
+    # amd64/StackFrame.cpp
+    # arm64/StackFrame.cpp
+    # arm/StackFrame.cpp
+    # i386/AsmJsJitTemplate.cpp
+    # i386/StackFrame.cpp
+    )
+
+include_directories (
+    ../Math
     )
 
 target_include_directories (

lib/Runtime/Language/CacheOperators.inl

@@ -435,7 +435,7 @@ namespace Js
             // polymorphic inline cache. Once resized, bailouts would populate only the new set of caches and full JIT would
             // continue to use to old set of caches.
             Assert(!info->AllowResizingPolymorphicInlineCache() || info->GetFunctionBody());
-            if((includeTypePropertyCache && !createTypePropertyCache || info->AllowResizingPolymorphicInlineCache()) &&
+            if(((includeTypePropertyCache && !createTypePropertyCache) || info->AllowResizingPolymorphicInlineCache()) &&
                 polymorphicInlineCache->HasDifferentType<IsAccessor>(isProto, type, typeWithoutProperty))
             {
                 if(info->AllowResizingPolymorphicInlineCache() && polymorphicInlineCache->CanAllocateBigger())

lib/Runtime/Language/InterpreterStackFrame.cpp

@@ -1833,7 +1833,7 @@ namespace Js
                 // Allocate invalidVar on GC instead of stack since this InterpreterStackFrame will out live the current real frame
                 Js::RecyclableObject* invalidVar = (Js::RecyclableObject*)RecyclerNewPlusLeaf(functionScriptContext->GetRecycler(), sizeof(Js::RecyclableObject), Var);
                 AnalysisAssert(invalidVar);
-                memset(invalidVar, 0xFE, sizeof(Js::RecyclableObject));
+                memset(reinterpret_cast<void*>(invalidVar), 0xFE, sizeof(Js::RecyclableObject));
                 newInstance = setup.InitializeAllocation(allocation, executeFunction->GetHasImplicitArgIns(), doProfile, loopHeaderArray, stackAddr, invalidVar);
 #else
                 newInstance = setup.InitializeAllocation(allocation, executeFunction->GetHasImplicitArgIns(), doProfile, loopHeaderArray, stackAddr);
@@ -1894,7 +1894,7 @@ namespace Js
 
 #if DBG
             Js::RecyclableObject * invalidStackVar = (Js::RecyclableObject*)_alloca(sizeof(Js::RecyclableObject));
-            memset(invalidStackVar, 0xFE, sizeof(Js::RecyclableObject));
+            memset(reinterpret_cast<void*>(invalidStackVar), 0xFE, sizeof(Js::RecyclableObject));
             newInstance = setup.InitializeAllocation(allocation, executeFunction->GetHasImplicitArgIns() && !isAsmJs, doProfile, loopHeaderArray, stackAddr, invalidStackVar);
 #else
             newInstance = setup.InitializeAllocation(allocation, executeFunction->GetHasImplicitArgIns() && !isAsmJs, doProfile, loopHeaderArray, stackAddr);
@@ -2769,7 +2769,7 @@ namespace Js
         Output::Print(_u("\n"));
     }
 
-#ifndef TEMP_DISABLE_ASMJS 
+#ifndef TEMP_DISABLE_ASMJS
     // Function memory allocation should be done the same way as
     // T AsmJsCommunEntryPoint(Js::ScriptFunction* func, ...)  (AsmJSJitTemplate.cpp)
     // update any changes there
@@ -3718,7 +3718,7 @@ namespace Js
         {
             flags |= CallFlags_NotUsed;
             Arguments args(CallInfo((CallFlags)flags, playout->ArgCount), m_outParams);
-            AssertMsg(args.Info.Flags == flags, "Flags don't fit into the CallInfo field?");
+            AssertMsg(static_cast<unsigned>(args.Info.Flags) == flags, "Flags don't fit into the CallInfo field?");
             if (spreadIndices != nullptr)
             {
                 JavascriptFunction::CallSpreadFunction(function, function->GetEntryPoint(), args, spreadIndices);
@@ -3732,7 +3732,7 @@ namespace Js
         {
             flags |= CallFlags_Value;
             Arguments args(CallInfo((CallFlags)flags, playout->ArgCount), m_outParams);
-            AssertMsg(args.Info.Flags == flags, "Flags don't fit into the CallInfo field?");
+            AssertMsg(static_cast<unsigned>(args.Info.Flags) == flags, "Flags don't fit into the CallInfo field?");
             if (spreadIndices != nullptr)
             {
                 SetReg((RegSlot)playout->Return, JavascriptFunction::CallSpreadFunction(function, function->GetEntryPoint(), args, spreadIndices));
@@ -5298,21 +5298,17 @@ namespace Js
 
         Assert(VirtualTableInfo<JavascriptArray>::HasVirtualTable(array));
         SparseArraySegment<Var>* lastUsedSeg = (SparseArraySegment<Var>*)array->GetLastUsedSegment();
-        if (index < lastUsedSeg->left)
+        if (index >= lastUsedSeg->left)
         {
-            goto helper;
-        }
-
-        uint32 index2 = index - lastUsedSeg->left;
-
-        if (index2 < lastUsedSeg->size)
-        {
-            // Successful fastpath
-            array->DirectSetItemInLastUsedSegmentAt(index2, value);
-            return;
+            uint32 index2 = index - lastUsedSeg->left;
+            if (index2 < lastUsedSeg->size)
+            {
+                // Successful fastpath
+                array->DirectSetItemInLastUsedSegmentAt(index2, value);
+                return;
+            }
         }
 
-    helper:
         ScriptContext* scriptContext = array->GetScriptContext();
         JavascriptOperators::SetItem(array, array, index, value, scriptContext);
     }
@@ -7588,7 +7584,7 @@ const byte * InterpreterStackFrame::OP_ProfiledLoopBodyStart(const byte * ip)
         values[5] = (int16) GetRegRawInt(playout->I6);
         values[6] = (int16) GetRegRawInt(playout->I7);
         values[7] = (int16) GetRegRawInt(playout->I8);
-        
+
         AsmJsSIMDValue result = SIMDInt16x8Operation::OpInt16x8(values);
         SetRegRawSimd(playout->I8_0, result);
     }
@@ -7621,7 +7617,7 @@ const byte * InterpreterStackFrame::OP_ProfiledLoopBodyStart(const byte * ip)
     template <class T>
     void InterpreterStackFrame::OP_SimdUint16x8(const unaligned T* playout)
     {
-        
+
         uint16 values[8];
         values[0] = (uint16) GetRegRawInt(playout->I1);
         values[1] = (uint16) GetRegRawInt(playout->I2);
@@ -7631,7 +7627,7 @@ const byte * InterpreterStackFrame::OP_ProfiledLoopBodyStart(const byte * ip)
         values[5] = (uint16) GetRegRawInt(playout->I6);
         values[6] = (uint16) GetRegRawInt(playout->I7);
         values[7] = (uint16) GetRegRawInt(playout->I8);
-        
+
         AsmJsSIMDValue result = SIMDUint16x8Operation::OpUint16x8(values);
         SetRegRawSimd(playout->U8_0, result);
     }
@@ -7686,7 +7682,7 @@ const byte * InterpreterStackFrame::OP_ProfiledLoopBodyStart(const byte * ip)
         values[5] = GetRegRawInt(playout->I6) ? true : false;
         values[6] = GetRegRawInt(playout->I7) ? true : false;
         values[7] = GetRegRawInt(playout->I8) ? true : false;
-        
+
         AsmJsSIMDValue result = SIMDBool16x8Operation::OpBool16x8(values);
         SetRegRawSimd(playout->B8_0, result);
     }
@@ -7711,7 +7707,7 @@ const byte * InterpreterStackFrame::OP_ProfiledLoopBodyStart(const byte * ip)
         values[13] = GetRegRawInt(playout->I14) ? true : false;
         values[14] = GetRegRawInt(playout->I15) ? true : false;
         values[15] = GetRegRawInt(playout->I16) ? true : false;
-        
+
         AsmJsSIMDValue result = SIMDBool8x16Operation::OpBool8x16(values);
         SetRegRawSimd(playout->B16_0, result);
     }
@@ -8334,7 +8330,7 @@ const byte * InterpreterStackFrame::OP_ProfiledLoopBodyStart(const byte * ip)
         return JavascriptOperators::OP_ResumeYield(yieldData, iterator);
     }
 
-    void* InterpreterStackFrame::operator new(size_t byteSize, void* previousAllocation)
+    void* InterpreterStackFrame::operator new(size_t byteSize, void* previousAllocation) throw()
     {
         //
         // Placement 'new' is used by InterpreterStackFrame to initialize the C++ object on the RcInterpreter's
@@ -8350,7 +8346,7 @@ const byte * InterpreterStackFrame::OP_ProfiledLoopBodyStart(const byte * ip)
         return previousAllocation;
     }
 
-    void __cdecl InterpreterStackFrame::operator delete(void * allocationToFree, void * previousAllocation)
+    void __cdecl InterpreterStackFrame::operator delete(void * allocationToFree, void * previousAllocation) throw()
     {
         AssertMsg(allocationToFree == previousAllocation, "Memory locations should match");
         AssertMsg(false, "This function should never actually be called");

lib/Runtime/Language/JavascriptConversion.cpp

@@ -9,9 +9,6 @@
 #include "Library/DateImplementation.h"
 #include "Library/JavascriptDate.h"
 
-extern "C" PVOID _ReturnAddress(VOID);
-#pragma intrinsic(_ReturnAddress)
-
 namespace Js
 {
     static const double k_2to16 = 65536.0;