fix wrong checks introduced during code analysis cleanup

Author: MikeHolman

lib/Backend/Encoder.cpp

@@ -372,6 +372,12 @@ Encoder::Encode()
         if (this->m_func->IsOOPJIT())
         {
             pinnedTypeRefs = (PinnedTypeRefsIDL*)midl_user_allocate(offsetof(PinnedTypeRefsIDL, typeRefs) + sizeof(void*)*pinnedTypeRefCount);
+            if (!pinnedTypeRefs)
+            {
+                Js::Throw::OutOfMemory();
+            }
+            __analysis_assume(pinnedTypeRefs);
+
             pinnedTypeRefs->count = pinnedTypeRefCount;
             pinnedTypeRefs->isOOPJIT = true;
             this->m_func->GetJITOutput()->GetOutputData()->pinnedTypeRefs = pinnedTypeRefs;
@@ -538,7 +544,7 @@ Encoder::Encode()
             {
                 auto count = srcSet->Count();
                 (*entry) = (TypeGuardTransferEntryIDL*)midl_user_allocate(offsetof(TypeGuardTransferEntryIDL, guardOffsets) + count*sizeof(int));
-                if (*entry)
+                if (!*entry)
                 {
                     Js::Throw::OutOfMemory();
                 }
@@ -584,12 +590,17 @@ Encoder::Encode()
             m_func->GetJITOutput()->GetOutputData()->ctorCachesCount = propertyCount;
             m_func->GetJITOutput()->GetOutputData()->ctorCacheEntries = (CtorCacheTransferEntryIDL**)midl_user_allocate(propertyCount * sizeof(CtorCacheTransferEntryIDL*));
             CtorCacheTransferEntryIDL** entries = m_func->GetJITOutput()->GetOutputData()->ctorCacheEntries;
+            if (!entries)
+            {
+                Js::Throw::OutOfMemory();
+            }
+            __analysis_assume(entries);
 
             uint propIndex = 0;
             m_func->ctorCachesByPropertyId->Map([func, entries, &propIndex](Js::PropertyId propertyId, Func::CtorCacheSet* srcCacheSet) -> void
             {
                 entries[propIndex] = (CtorCacheTransferEntryIDL*)midl_user_allocate(srcCacheSet->Count() * sizeof(intptr_t) + sizeof(CtorCacheTransferEntryIDL));
-                if (entries[propIndex])
+                if (!entries[propIndex])
                 {
                     Js::Throw::OutOfMemory();
                 }

lib/Backend/Func.cpp

@@ -577,14 +577,20 @@ Func::TryCodegen()
             JITOutputIDL* jitOutputData = m_output.GetOutputData();
             size_t allocSize = offsetof(NativeDataFixupTable, fixupRecords) + sizeof(NativeDataFixupRecord)* (dataAllocator->allocCount);
             jitOutputData->nativeDataFixupTable = (NativeDataFixupTable*)midl_user_allocate(allocSize);
-            if (jitOutputData->nativeDataFixupTable)
+            if (!jitOutputData->nativeDataFixupTable)
             {
                 Js::Throw::OutOfMemory();
             }
             __analysis_assume(jitOutputData->nativeDataFixupTable);
             jitOutputData->nativeDataFixupTable->count = dataAllocator->allocCount;
 
             jitOutputData->buffer = (NativeDataBuffer*)midl_user_allocate(offsetof(NativeDataBuffer, data) + dataAllocator->totalSize);
+            if (!jitOutputData->buffer)
+            {
+                Js::Throw::OutOfMemory();
+            }
+            __analysis_assume(jitOutputData->buffer);
+
             jitOutputData->buffer->len = dataAllocator->totalSize;
 
             unsigned int len = 0;

lib/Backend/NativeCodeData.cpp

@@ -69,7 +69,7 @@ NativeCodeData::AddFixupEntry(void* targetAddr, void* targetStartAddr, void* add
     DataChunk* chunk = NativeCodeData::GetDataChunk(startAddress);
 
     NativeDataFixupEntry* entry = (NativeDataFixupEntry*)midl_user_allocate(sizeof(NativeDataFixupEntry));
-    if (entry)
+    if (!entry)
     {
         Js::Throw::OutOfMemory();
     }
@@ -119,7 +119,7 @@ NativeCodeData::AddFixupEntryForPointerArray(void* startAddress, DataChunk * chu
 #endif
 
         NativeDataFixupEntry* entry = (NativeDataFixupEntry*)midl_user_allocate(sizeof(NativeDataFixupEntry));
-        if (entry)
+        if (!entry)
         {
             Js::Throw::OutOfMemory();
         }

lib/Backend/NativeCodeGenerator.cpp

@@ -905,7 +905,7 @@ NativeCodeGenerator::CodeGen(PageAllocator * pageAllocator, CodeGenWorkItem* wor
         case E_ABORT:
             throw Js::OperationAbortedException();
         case E_OUTOFMEMORY:
-            throw Js::OutOfMemoryException();
+            Js::Throw::OutOfMemory();
         case VBSERR_OutOfStack:
             throw Js::StackOverflowException();
         default:

lib/JITServer/JITServer.cpp

@@ -412,6 +412,15 @@ ServerRemoteCodeGen(
 #endif
 
     jitData->numberPageSegments = (XProcNumberPageSegment*)midl_user_allocate(sizeof(XProcNumberPageSegment));
+    if (!jitData->numberPageSegments)
+    {
+        scriptContextInfo->EndJIT();
+        threadContextInfo->EndJIT();
+
+        return E_OUTOFMEMORY;
+    }
+    __analysis_assume(jitData->numberPageSegments);
+
     memcpy_s(jitData->numberPageSegments, sizeof(XProcNumberPageSegment), jitWorkItem->GetWorkItemData()->xProcNumberPageSegment, sizeof(XProcNumberPageSegment));
 
     HRESULT hr = S_OK;
@@ -433,14 +442,17 @@ ServerRemoteCodeGen(
     }
     catch (Js::OutOfMemoryException)
     {
+        memset(jitData, 0, sizeof(JITOutputIDL));
         hr = E_OUTOFMEMORY;
     }
     catch (Js::StackOverflowException)
     {
+        memset(jitData, 0, sizeof(JITOutputIDL));
         hr = VBSERR_OutOfStack;
     }
     catch (Js::OperationAbortedException)
     {
+        memset(jitData, 0, sizeof(JITOutputIDL));
         hr = E_ABORT;
     }
     scriptContextInfo->EndJIT();