Not pulling from `eslint:recommended`

[avegancafe]

Recently I noticed that on codeclimate, some of the rules in eslint:recommended ruleset are not enabled. Is there any special config that I have to enable to get this to work? Specifically, I saw that the no-inner-declarations rule was ignored.

[dblandin]

@kyleholzinger Do you have "extends": "eslint:recommended" in your ESLint config?

If you don't have an ESLint configuration file within your repo, we use this as the inferred configuration, which does not extend from eslint:recommended: https://github.com/codeclimate/codeclimate/blob/master/config/eslint/.eslintrc.yml

[avegancafe]

Yeah, we have a .eslintrc.json file in our repo @dblandin

[avegancafe]

// .eslintrc.json
{
  "env": {
    "browser": true,
    "es6": true
  },
  "plugins": ["mocha"],
  "extends": "eslint:recommended",
  "rules": {
    "all the rules go here": true
  }
}

# .codeclimate.yml
---
engines:
  eslint:
    enabled: true
    channel: "eslint-3"
ratings:
  paths:
  - "**.js"

[dblandin]

Unfortunately I'm not able to reproduce this with a new repo using the same configuration:

https://github.com/codeclimate-testing/eslint-no-inner-declarations-test

You can see the "Move function declaration to function body root." issues on Code Climate after the first build:

https://codeclimate.com/github/codeclimate-testing/eslint-no-inner-declarations-test/issues

[avegancafe]

Oops! This is totally my bad, I didn't realize you could mark linter errors as "wont fix". Thanks @dblandin ! I'm glad this wasn't some issue with the config.