Skip to content
This repository was archived by the owner on Jan 19, 2023. It is now read-only.

Commit 583a9d3

Browse files
JiaLiPassionmhevery
authored andcommitted
feat(zone.js): upgrade zone.js to angular package format(APF) (angular#36540)
Close angular#35157 In the current version of zone.js, zone.js uses it's own package format, and it is not following the rule of Angualr package format(APF), so it is not easily to be consumed by Angular CLI or other bundle tools. For example, zone.js npm package has two bundles, 1. zone.js/dist/zone.js, this is a `es5` bundle. 2. zone.js/dist/zone-evergreen.js, this is a `es2015` bundle. And Angular CLI has to add some hard-coding code to handle this case, ohttps://github.com/angular/angular-cli/blob/5376a8b1392ac7bd252782d8474161ce03a4d1cb/packages/schematics/angular/application/files/src/polyfills.ts.template#L55-L58 This PR upgrade zone.js npm package format to follow APF rule, https://docs.google.com/document/d/1CZC2rcpxffTDfRDs6p1cfbmKNLA6x5O-NtkJglDaBVs/edit#heading=h.k0mh3o8u5hx The updated points are: 1. in package.json, update all bundle related properties ``` "main": "./bundles/zone.umd.js", "module": "./fesm2015/zone.js", "es2015": "./fesm2015/zone.js", "fesm2015": "./fesm2015/zone.js", ``` 2. re-organize dist folder, for example for `zone.js` bundle, now we have ``` dist/ bundles/ zone.js // this is the es5 bundle fesm2015/ zone.js // this is the es2015 bundle (in the old version is `zone-evergreen.js`) ``` 3. have several sub-packages. 1. `zone-testing`, provide zone-testing bundles include zone.js and testing libraries 2. `zone-node`, provide zone.js implemention for NodeJS 3. `zone-mix`, provide zone.js patches for both Browser and NodeJS All those sub-packages will have their own `package.json` and the bundle will reference `bundles(es5)` and `fesm2015(es2015)`. 4. keep backward compatibility, still keep the `zone.js/dist` folder, and all bundles will be redirected to `zone.js/bundles` or `zone.js/fesm2015` folders. PR Close angular#36540
1 parent 1fce6d6 commit 583a9d3

File tree

182 files changed

+1708
-902
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

182 files changed

+1708
-902
lines changed

.circleci/config.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -731,8 +731,8 @@ jobs:
731731
- run: yarn --cwd packages/zone.js promisetest
732732
- run: yarn --cwd packages/zone.js promisefinallytest
733733
- run: yarn bazel build //packages/zone.js:npm_package &&
734-
cp dist/bin/packages/zone.js/npm_package/dist/zone-mix.js ./packages/zone.js/test/extra/ &&
735-
cp dist/bin/packages/zone.js/npm_package/dist/zone-patch-electron.js ./packages/zone.js/test/extra/ &&
734+
cp dist/bin/packages/zone.js/npm_package/bundles/zone-mix.umd.js ./packages/zone.js/test/extra/ &&
735+
cp dist/bin/packages/zone.js/npm_package/bundles/zone-patch-electron.umd.js ./packages/zone.js/test/extra/ &&
736736
yarn --cwd packages/zone.js electrontest
737737
- run: yarn --cwd packages/zone.js jesttest
738738

BUILD.bazel

+3-3
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,9 @@ filegroup(
2020
# do not sort
2121
srcs = [
2222
"@npm//:node_modules/core-js/client/core.js",
23-
"//packages/zone.js/dist:zone.js",
24-
"//packages/zone.js/dist:zone-testing.js",
25-
"//packages/zone.js/dist:task-tracking.js",
23+
"//packages/zone.js/bundles:zone.umd.js",
24+
"//packages/zone.js/bundles:zone-testing.umd.js",
25+
"//packages/zone.js/bundles:task-tracking.umd.js",
2626
"//:test-events.js",
2727
"//:shims_for_IE.js",
2828
# Including systemjs because it defines `__eval`, which produces correct stack traces.

aio/content/examples/setup/src/index.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
<!-- Polyfills -->
1212
<script src="node_modules/core-js/client/shim.min.js"></script>
1313

14-
<script src="node_modules/zone.js/dist/zone.js"></script>
14+
<script src="node_modules/zone.js/bundles/zone.umd.js"></script>
1515
<script src="node_modules/systemjs/dist/system.src.js"></script>
1616
<script src="systemjs.config.js"></script>
1717
<script>

aio/content/examples/upgrade-module/src/index-a-to-ajs-providers.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
<!-- Polyfills -->
1313
<script src="node_modules/core-js/client/shim.min.js"></script>
1414

15-
<script src="node_modules/zone.js/dist/zone.js"></script>
15+
<script src="node_modules/zone.js/bundles/zone.umd.js"></script>
1616
<script src="node_modules/systemjs/dist/system.src.js"></script>
1717

1818
<script src="systemjs.config.1.js"></script>

aio/content/examples/upgrade-module/src/index-a-to-ajs-transclusion.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
<!-- Polyfills -->
1313
<script src="node_modules/core-js/client/shim.min.js"></script>
1414

15-
<script src="node_modules/zone.js/dist/zone.js"></script>
15+
<script src="node_modules/zone.js/bundles/zone.umd.js"></script>
1616
<script src="node_modules/systemjs/dist/system.src.js"></script>
1717

1818
<script src="systemjs.config.1.js"></script>

aio/content/examples/upgrade-module/src/index-ajs-a-hybrid-bootstrap.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
<!-- Polyfills -->
1313
<script src="node_modules/core-js/client/shim.min.js"></script>
1414

15-
<script src="node_modules/zone.js/dist/zone.js"></script>
15+
<script src="node_modules/zone.js/bundles/zone.umd.js"></script>
1616
<script src="node_modules/systemjs/dist/system.src.js"></script>
1717

1818
<script src="systemjs.config.1.js"></script>

aio/content/examples/upgrade-module/src/index-ajs-to-a-projection.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
<!-- Polyfills -->
1313
<script src="node_modules/core-js/client/shim.min.js"></script>
1414

15-
<script src="node_modules/zone.js/dist/zone.js"></script>
15+
<script src="node_modules/zone.js/bundles/zone.umd.js"></script>
1616
<script src="node_modules/systemjs/dist/system.src.js"></script>
1717

1818
<script src="systemjs.config.1.js"></script>

aio/content/examples/upgrade-module/src/index-ajs-to-a-providers.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
<!-- Polyfills -->
1313
<script src="node_modules/core-js/client/shim.min.js"></script>
1414

15-
<script src="node_modules/zone.js/dist/zone.js"></script>
15+
<script src="node_modules/zone.js/bundles/zone.umd.js"></script>
1616
<script src="node_modules/systemjs/dist/system.src.js"></script>
1717

1818
<script src="systemjs.config.1.js"></script>

aio/content/examples/upgrade-module/src/index-downgrade-io.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
<!-- Polyfills -->
1313
<script src="node_modules/core-js/client/shim.min.js"></script>
1414

15-
<script src="node_modules/zone.js/dist/zone.js"></script>
15+
<script src="node_modules/zone.js/bundles/zone.umd.js"></script>
1616
<script src="node_modules/systemjs/dist/system.src.js"></script>
1717

1818
<script src="systemjs.config.1.js"></script>

aio/content/examples/upgrade-module/src/index-downgrade-static.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
<!-- Polyfills -->
1313
<script src="node_modules/core-js/client/shim.min.js"></script>
1414

15-
<script src="node_modules/zone.js/dist/zone.js"></script>
15+
<script src="node_modules/zone.js/bundles/zone.umd.js"></script>
1616
<script src="node_modules/systemjs/dist/system.src.js"></script>
1717

1818
<script src="systemjs.config.1.js"></script>

aio/content/examples/upgrade-module/src/index-upgrade-io.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
<!-- Polyfills -->
1313
<script src="node_modules/core-js/client/shim.min.js"></script>
1414

15-
<script src="node_modules/zone.js/dist/zone.js"></script>
15+
<script src="node_modules/zone.js/bundles/zone.umd.js"></script>
1616
<script src="node_modules/systemjs/dist/system.src.js"></script>
1717

1818
<script src="systemjs.config.1.js"></script>

aio/content/examples/upgrade-module/src/index-upgrade-static.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
<!-- Polyfills -->
1313
<script src="node_modules/core-js/client/shim.min.js"></script>
1414

15-
<script src="node_modules/zone.js/dist/zone.js"></script>
15+
<script src="node_modules/zone.js/bundles/zone.umd.js"></script>
1616
<script src="node_modules/systemjs/dist/system.src.js"></script>
1717

1818
<script src="systemjs.config.1.js"></script>

aio/content/examples/upgrade-phonecat-2-hybrid/aot/index.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
<script src="phone-detail/phone-detail.module.js"></script>
2727

2828
<script src="/node_modules/core-js/client/shim.min.js"></script>
29-
<script src="/node_modules/zone.js/dist/zone.min.js"></script>
29+
<script src="/node_modules/zone.js/bundles/zone.umd.min.js"></script>
3030

3131
<script>window.module = 'aot';</script>
3232
</head>

aio/content/examples/upgrade-phonecat-2-hybrid/copy-dist-files.js

+3-2
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ var fsExtra = require('fs-extra');
33
var resources = [
44
// polyfills
55
'node_modules/core-js/client/shim.min.js',
6-
'node_modules/zone.js/dist/zone.min.js',
6+
'node_modules/zone.js/bundles/zone.umd.min.js',
77
// css
88
'app/app.css',
99
'app/app.animations.css',
@@ -20,6 +20,7 @@ var resources = [
2020
'app/phone-detail/phone-detail.module.js'
2121
];
2222
resources.map(function(sourcePath) {
23-
var destPath = `aot/${sourcePath}`;
23+
// Need to rename zone.umd.min.js to zone.min.js
24+
var destPath = `aot/${sourcePath}`.replace('.umd.min.js', '.min.js');
2425
fsExtra.copySync(sourcePath, destPath);
2526
});

aio/content/examples/upgrade-phonecat-2-hybrid/index.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727

2828
<!-- #docregion angular -->
2929
<script src="/node_modules/core-js/client/shim.min.js"></script>
30-
<script src="/node_modules/zone.js/dist/zone.js"></script>
30+
<script src="/node_modules/zone.js/bundles/zone.umd.js"></script>
3131
<script src="/node_modules/systemjs/dist/system.src.js"></script>
3232
<!-- #enddocregion angular -->
3333
<script src="/systemjs.config.1.js"></script>

aio/content/examples/upgrade-phonecat-2-hybrid/karma.conf.ajs.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,8 @@ module.exports = function(config) {
2121
'node_modules/core-js/client/shim.js',
2222

2323
// zone.js
24-
'node_modules/zone.js/dist/zone.js',
25-
'node_modules/zone.js/dist/zone-testing.js',
24+
'node_modules/zone.js/bundles/zone.umd.js',
25+
'node_modules/zone.js/bundles/zone-testing.umd.js',
2626

2727
// RxJs.
2828
{ pattern: 'node_modules/rxjs/**/*.js', included: false, watched: false },

aio/content/examples/upgrade-phonecat-2-hybrid/karma.conf.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,8 @@ module.exports = function(config) {
3131
'node_modules/core-js/client/shim.js',
3232

3333
// zone.js
34-
'node_modules/zone.js/dist/zone.js',
35-
'node_modules/zone.js/dist/zone-testing.js',
34+
'node_modules/zone.js/bundles/zone.umd.js',
35+
'node_modules/zone.js/bundles/zone-testing.umd.js',
3636

3737
// RxJs
3838
{ pattern: 'node_modules/rxjs/**/*.js', included: false, watched: false },

aio/content/examples/upgrade-phonecat-3-final/index.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
<link rel="stylesheet" href="app.css" />
1313

1414
<script src="/node_modules/core-js/client/shim.min.js"></script>
15-
<script src="/node_modules/zone.js/dist/zone.js"></script>
15+
<script src="/node_modules/zone.js/bundles/zone.umd.js"></script>
1616
<script src="/node_modules/systemjs/dist/system.src.js"></script>
1717
<!-- #enddocregion full -->
1818
<script src="/systemjs.config.1.js"></script>

aio/content/examples/upgrade-phonecat-3-final/karma.conf.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,8 @@ module.exports = function(config) {
3131
'node_modules/core-js/client/shim.js',
3232

3333
// zone.js
34-
'node_modules/zone.js/dist/zone.js',
35-
'node_modules/zone.js/dist/zone-testing.js',
34+
'node_modules/zone.js/bundles/zone.umd.js',
35+
'node_modules/zone.js/bundles/zone-testing.umd.js',
3636

3737
// RxJs
3838
{ pattern: 'node_modules/rxjs/**/*.js', included: false, watched: false },

aio/content/guide/browser-support.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -526,7 +526,7 @@ For example:
526526
// __Zone_enable_cross_context_check = true;
527527
&lt;/script>
528528
&lt;!-- zone.js required by Angular -->
529-
&lt;script src="node_modules/zone.js/dist/zone.js">&lt;/script>
529+
&lt;script src="node_modules/zone.js/bundles/zone.umd.js">&lt;/script>
530530

531531
&lt;!-- application polyfills -->
532532
</code-example>

aio/content/guide/universal.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -227,7 +227,7 @@ as a navigation URL intended for the router.
227227

228228
Fortunately, application routes have something in common: their URLs lack file extensions.
229229
(Data requests also lack extensions but they're easy to recognize because they always begin with `/api`.)
230-
All static asset requests have a file extension (such as `main.js` or `/node_modules/zone.js/dist/zone.js`).
230+
All static asset requests have a file extension (such as `main.js` or `/node_modules/zone.js/bundles/zone.umd.js`).
231231

232232
Because we use routing, we can easily recognize the three types of requests and handle them differently.
233233

dev-infra/benchmark/component_benchmark/component_benchmark.bzl

+1-1
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ def component_benchmark(
129129
# The server for our application.
130130
ts_devserver(
131131
name = server,
132-
bootstrap = ["//packages/zone.js/dist:zone.js"],
132+
bootstrap = ["//packages/zone.js/bundles:zone.umd.js"],
133133
port = 4200,
134134
static_files = assets + styles,
135135
deps = [":" + app_main + ".min_debug.es2015.js"],

integration/bazel/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
"reflect-metadata": "0.1.12",
1717
"rxjs": "file:../../node_modules/rxjs",
1818
"tslib": "file:../../node_modules/tslib",
19-
"zone.js": "0.10.3"
19+
"zone.js": "file:../../dist/zone.js-dist"
2020
},
2121
"devDependencies": {
2222
"@angular/bazel": "file:../../dist/packages-dist/bazel",

integration/bazel/src/BUILD.bazel

+2-2
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ ts_devserver(
4646
serving_path = "/bundle.min.js",
4747
static_files = [
4848
"index.html",
49-
"@npm//:node_modules/zone.js/dist/zone.min.js",
49+
"@npm//:node_modules/zone.js/bundles/zone.umd.min.js",
5050
],
5151
deps = ["//src"],
5252
)
@@ -72,7 +72,7 @@ pkg_web(
7272
srcs = [
7373
"index.html",
7474
":bundle.min",
75-
"@npm//:node_modules/zone.js/dist/zone.min.js",
75+
"@npm//:node_modules/zone.js/bundles/zone.umd.min.js",
7676
],
7777
)
7878

integration/bazel/src/hello-world/BUILD.bazel

+1-1
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ ts_library(
4949
karma_web_test_suite(
5050
name = "test",
5151
bootstrap = [
52-
"@npm//:node_modules/zone.js/dist/zone-testing-bundle.js",
52+
"@npm//:node_modules/zone.js/bundles/zone-testing-bundle.umd.js",
5353
"@npm//:node_modules/reflect-metadata/Reflect.js",
5454
],
5555
browsers = [

integration/bazel/src/index.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
<body>
1010
<!-- The Angular application will be bootstrapped into this element. -->
1111
<app-component></app-component>
12-
<script src="/npm/node_modules/zone.js/dist/zone.min.js"></script>
12+
<script src="/npm/node_modules/zone.js/bundles/zone.umd.min.js"></script>
1313
<script src="/bundle.min.js"></script>
1414
</body>
1515
</html>

0 commit comments

Comments
 (0)