chore: Fix stack trace lines when calculating code frame #31935
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the code frame. Accounts additionally for node:diagnostics_channel
cacieprins
approved these changes
Jun 24, 2025
cypress
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
chore/fix_stack_trace_lines
|
| Run status |
|
| Run duration | 19m 55s |
| Commit |
|
| Committer | Bill Glesias |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
3
|
Flaky
|
3
|
Pending
|
174
|
Skipped
|
0
|
Passing
|
12657
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
0%
|
|
|---|---|
|
Untested elements
|
4
|
|
Tested elements
|
0
|
Accessibility
97.09%
|
|
|---|---|
|
Failed rules
|
0 critical
1 serious
0 moderate
0 minor
|
|
Failed elements
|
4
|
Tests for review
runner/ui-states.cy.ts • 2 failed tests • app-e2e
| Test | Artifacts | |
|---|---|---|
| src/cypress/runner ui states > status codes |
Test Replay
Screenshots
|
|
| src/cypress/runner ui states > errors > long error |
Test Replay
Screenshots
|
|
studio/studio.cy.ts • 1 failed test • app-e2e
| Test | Artifacts | |
|---|---|---|
| Cypress Studio > exits studio mode if the spec is removed on the file system |
Test Replay
Screenshots
|
|
commands/location.cy.js • 1 flaky test • 5x-driver-electron
| Test | Artifacts | |
|---|---|---|
| ... > eventually fails the assertion |
Test Replay
|
|
issues/28527.cy.ts • 1 flaky test • 5x-driver-electron
| Test | Artifacts | |
|---|---|---|
| issue 28527 > fails and then retries and verifies about:blank is not displayed |
Test Replay
Screenshots
|
|
issues/28527.cy.ts • 1 flaky test • 5x-driver-chrome
| Test | Artifacts | |
|---|---|---|
| issue 28527 > fails and then retries and verifies about:blank is not displayed |
Test Replay
Screenshots
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
With the new node used in Electron 36 (v22.15.1), it looks like our stack traces now contain
node:diagnostics_channelin the stack. We really want to filter out all node internal stacks when calculating the code frame. This code changes the code slightly to make sure these values are filtered out.Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?