Skip to content

chore: Update Chrome (stable) to 138.0.7204.49 and Chrome (beta) to 139.0.7258.5 #31936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

github-actions[bot]
Copy link
Contributor

This PR was auto-generated to update the version(s) of Chrome for driver tests

Copy link

cypress bot commented Jun 25, 2025

cypress    Run #63312

Run Properties:  status check failed Failed #63312  •  git commit adc7dda28a: remove invalid attribute HTML test
Project cypress
Branch Review update-chrome-stable-from-137.0.7151.119-beta-from-138.0.7204.35
Run status status check failed Failed #63312
Run duration 15m 14s
Commit git commit adc7dda28a: remove invalid attribute HTML test
Committer Jennifer Shehane
View all properties for this run ↗︎

Test results
Tests that failed  Failures 2
Tests that were flaky  Flaky 2
Tests that did not run due to a developer annotating a test with .skip  Pending 10
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 609
View all changes introduced in this branch ↗︎
UI Coverage  0%
  Untested elements 4  
  Tested elements 0  
Accessibility  97.09%
  Failed rules  0 critical   1 serious   0 moderate   0 minor
  Failed elements 4  

Tests for review

Failed  cypress/e2e/runner/ui-states.cy.ts • 2 failed tests • app-e2e

View Output

Test Artifacts
src/cypress/runner ui states > status codes Test Replay Screenshots
src/cypress/runner ui states > errors > long error Test Replay Screenshots
Flakiness  cypress/e2e/studio/studio.cy.ts • 2 flaky tests • app-e2e

View Output

Test Artifacts
Cypress Studio > creates a new test for an existing spec with the url already defined Test Replay Screenshots
Cypress Studio > does not remove the studio url parameters if saving fails Test Replay Screenshots

@github-actions github-actions bot changed the title chore: Update Chrome (stable) to 138.0.7204.49 chore: Update Chrome (stable) to 138.0.7204.49 and Chrome (beta) to 139.0.7258.5 Jun 26, 2025
@jennifer-shehane
Copy link
Member

jennifer-shehane commented Jun 26, 2025

In Chrome 139: https://developer.chrome.com/blog/chrome-139-beta there is the following change:

  • Allow more characters in JavaScript DOM APIs: The HTML parser has always (or for a long time) allowed elements and attributes to have a wide variety of valid characters and names, but the JavaScript DOM APIs that create the same elements and attributes are more strict and don't match the parser. This change relaxes the validation of the JavaScript DOM APIs to match the HTML parser.

This change causes this failure:
Screenshot 2025-06-26 at 2 03 34 PM

Where we are attempting to take a snapshot of this HTML and expecting the setAttributes to throw a failure.
Screenshot 2025-06-26 at 2 07 12 PM

From this area in the code: https://github.com/cypress-io/cypress/blob/develop/packages/driver/src/cy/snapshots.ts#L29

Chrome 138 behavior:
Screenshot 2025-06-26 at 2 36 25 PM

Chrome 139 behavior:
Screenshot 2025-06-26 at 2 36 10 PM

I could not actually find a way to set an invalid attribute in HTML anymore in Chrome 139. It's very forgiving! So I am removing this test. I suppose we could mock setAttribute throwing??

@jennifer-shehane jennifer-shehane merged commit 47bd448 into develop Jun 26, 2025
82 of 88 checks passed
@jennifer-shehane jennifer-shehane deleted the update-chrome-stable-from-137.0.7151.119-beta-from-138.0.7204.35 branch June 26, 2025 20:39
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jul 1, 2025

Released in 14.5.1.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v14.5.1, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Jul 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants