-
Notifications
You must be signed in to change notification settings - Fork 3.3k
chore: Update Chrome (stable) to 138.0.7204.49 and Chrome (beta) to 139.0.7258.5 #31936
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update Chrome (stable) to 138.0.7204.49 and Chrome (beta) to 139.0.7258.5 #31936
Conversation
In Chrome 139: https://developer.chrome.com/blog/chrome-139-beta there is the following change:
This change causes this failure: Where we are attempting to take a snapshot of this HTML and expecting the From this area in the code: https://github.com/cypress-io/cypress/blob/develop/packages/driver/src/cy/snapshots.ts#L29 I could not actually find a way to set an invalid attribute in HTML anymore in Chrome 139. It's very forgiving! So I am removing this test. I suppose we could mock setAttribute throwing?? |
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
This PR was auto-generated to update the version(s) of Chrome for driver tests