build: run largetable benchmark tests with bazel (angular#28645)

PR Close angular#28645

Author: devversion

modules/benchmarks/e2e_test/largetable_perf.ts

@@ -11,12 +11,9 @@ ts_library(
 ts_library(
     name = "perf_lib",
     testonly = 1,
-    srcs = [
-        "largetable_perf.spec.ts",
-    ],
+    srcs = ["largetable_perf.spec.ts"],
     deps = [
         "//modules/e2e_util",
-        "//packages:types",
         "@ngdeps//protractor",
     ],
 )

modules/benchmarks/e2e_test/largetable_spec.ts

@@ -1,5 +1,6 @@
 load("//tools:defaults.bzl", "ts_library")
 load("@build_bazel_rules_typescript//:defs.bzl", "ts_devserver")
+load("//modules/benchmarks:benchmark_test.bzl", "benchmark_test")
 
 package(default_visibility = ["//modules/benchmarks:__subpackages__"])
 
@@ -20,3 +21,9 @@ ts_devserver(
     port = 4200,
     deps = [":baseline"],
 )
+
+benchmark_test(
+    name = "perf",
+    server = ":devserver",
+    deps = ["//modules/benchmarks/src/largetable:perf_lib"],
+)

modules/benchmarks/src/largetable/BUILD.bazel

@@ -1,5 +1,6 @@
 load("//tools:defaults.bzl", "ts_library")
 load("@build_bazel_rules_typescript//:defs.bzl", "ts_devserver")
+load("//modules/benchmarks:benchmark_test.bzl", "benchmark_test")
 
 package(default_visibility = ["//modules/benchmarks:__subpackages__"])
 
@@ -23,3 +24,9 @@ ts_devserver(
     ],
     deps = [":incremental_dom"],
 )
+
+benchmark_test(
+    name = "perf",
+    server = ":devserver",
+    deps = ["//modules/benchmarks/src/largetable:perf_lib"],
+)

modules/benchmarks/src/largetable/baseline/BUILD.bazel

@@ -1,5 +1,6 @@
 load("//tools:defaults.bzl", "ts_library")
 load("@build_bazel_rules_typescript//:defs.bzl", "ts_devserver")
+load("//modules/benchmarks:benchmark_test.bzl", "benchmark_test")
 
 package(default_visibility = ["//modules/benchmarks:__subpackages__"])
 
@@ -9,3 +10,9 @@ ts_devserver(
     port = 4200,
     static_files = ["largetable.js"],
 )
+
+benchmark_test(
+    name = "perf",
+    server = ":devserver",
+    deps = ["//modules/benchmarks/src/largetable:perf_lib"],
+)

modules/benchmarks/src/largetable/incremental_dom/BUILD.bazel

@@ -36,11 +36,19 @@ const UpdateWorker: Worker = {
   work: () => $('#createDom').click()
 };
 
+// In order to make sure that we don't change the ids of the benchmarks, we need to
+// determine the current test package name from the Bazel target. This is necessary
+// because previous to the Bazel conversion, the benchmark test ids contained the test
+// name. e.g. "largeTable.ng2_switch.createDestroy". We determine the name of the
+// Bazel package where this test runs from the current test target. The Bazel target
+// looks like: "//modules/benchmarks/src/largetable/{pkg_name}:{target_name}".
+const testPackageName = process.env['BAZEL_TARGET'] !.split(':')[0].split('/').pop();
+
 describe('largetable benchmark perf', () => {
 
   afterEach(verifyNoBrowserErrors);
 
-  it('should render the table for render3', () => {
+  it(`should render the table for ${testPackageName}`, () => {
     openBrowser({
       url: '',
       ignoreBrowserSynchronization: true,
@@ -56,26 +64,26 @@ describe('largetable benchmark perf', () => {
 
   [CreateOnlyWorker, CreateAndDestroyWorker, UpdateWorker].forEach((worker) => {
     describe(worker.id, () => {
-      it('should run benchmark for render3', done => {
+      it(`should run benchmark for ${testPackageName}`, done => {
         runTableBenchmark({
-          id: `largeTable.render3.${worker.id}`,
-          url: 'index.html',
+          id: `largeTable.${testPackageName}.${worker.id}`,
+          url: '/',
           ignoreBrowserSynchronization: true,
           worker: worker
         }).then(done, done.fail);
       });
     });
   });
-
-  function runTableBenchmark(
-      config: {id: string, url: string, ignoreBrowserSynchronization?: boolean, worker: Worker}) {
-    return runBenchmark({
-      id: config.id,
-      url: config.url,
-      ignoreBrowserSynchronization: config.ignoreBrowserSynchronization,
-      params: [{name: 'cols', value: 40}, {name: 'rows', value: 200}],
-      prepare: config.worker.prepare,
-      work: config.worker.work
-    });
-  }
 });
+
+function runTableBenchmark(
+    config: {id: string, url: string, ignoreBrowserSynchronization?: boolean, worker: Worker}) {
+  return runBenchmark({
+    id: config.id,
+    url: config.url,
+    ignoreBrowserSynchronization: config.ignoreBrowserSynchronization,
+    params: [{name: 'cols', value: 40}, {name: 'rows', value: 200}],
+    prepare: config.worker.prepare,
+    work: config.worker.work
+  });
+}

modules/benchmarks/src/largetable/iv/BUILD.bazel

@@ -1,5 +1,6 @@
 load("//tools:defaults.bzl", "ng_module")
 load("@build_bazel_rules_typescript//:defs.bzl", "ts_devserver")
+load("//modules/benchmarks:benchmark_test.bzl", "benchmark_test")
 
 package(default_visibility = ["//modules/benchmarks:__subpackages__"])
 
@@ -33,3 +34,9 @@ ts_devserver(
     ],
     deps = [":ng2"],
 )
+
+benchmark_test(
+    name = "perf",
+    server = ":devserver",
+    deps = ["//modules/benchmarks/src/largetable:perf_lib"],
+)

modules/benchmarks/src/largetable/largetable_perf.spec.ts

@@ -1,5 +1,6 @@
 load("//tools:defaults.bzl", "ng_module")
 load("@build_bazel_rules_typescript//:defs.bzl", "ts_devserver")
+load("//modules/benchmarks:benchmark_test.bzl", "benchmark_test")
 
 package(default_visibility = ["//modules/benchmarks:__subpackages__"])
 
@@ -30,3 +31,9 @@ ts_devserver(
     ],
     deps = [":ng2_switch"],
 )
+
+benchmark_test(
+    name = "perf",
+    server = ":devserver",
+    deps = ["//modules/benchmarks/src/largetable:perf_lib"],
+)

modules/benchmarks/src/largetable/ng2/BUILD.bazel

@@ -1,17 +1,12 @@
 package(default_visibility = ["//visibility:public"])
 
 load("//tools:defaults.bzl", "ng_module", "ng_rollup_bundle")
-load("//packages/bazel:index.bzl", "protractor_web_test_suite")
 load("@build_bazel_rules_typescript//:defs.bzl", "ts_devserver")
+load("//modules/benchmarks:benchmark_test.bzl", "benchmark_test")
 
 ng_module(
     name = "largetable_lib",
-    srcs = glob(
-        [
-            "**/*.ts",
-        ],
-        exclude = ["protractor.on-prepare.ts"],
-    ),
+    srcs = glob(["**/*.ts"]),
     tags = ["ivy-only"],
     deps = [
         "//modules/benchmarks/src:util_lib",
@@ -42,23 +37,9 @@ ts_devserver(
     tags = ["ivy-only"],
 )
 
-protractor_web_test_suite(
+benchmark_test(
     name = "perf",
-    configuration = "//:protractor-perf.conf.js",
-    data = [
-        "//packages/bazel/src/protractor/utils",
-        "//packages/benchpress",
-        "@ngdeps//node-uuid",
-        "@ngdeps//protractor",
-        "@ngdeps//reflect-metadata",
-        "@ngdeps//yargs",
-    ],
-    on_prepare = ":protractor.on_prepare.js",
     server = ":devserver",
-    tags = [
-        "ivy-only",
-    ],
-    deps = [
-        "//modules/benchmarks/src/largetable:perf_lib",
-    ],
+    tags = ["ivy-only"],
+    deps = ["//modules/benchmarks/src/largetable:perf_lib"],
 )