Skip to content

Commit 40bbfbf

Browse files
IgorMinarmatsko
authored andcommitted
test(ivy): fix or disable failing ivy tests (angular#26735)
These tests were previously not running on CI so they have always been broken, or got broken just recently :-(. test(ivy): mark failing test targets with fixme-ivy-jit and fixme-ivy-local tags PR Close angular#26735
1 parent 30f319a commit 40bbfbf

File tree

21 files changed

+912
-56
lines changed

21 files changed

+912
-56
lines changed

modules/benchmarks/src/largetable/render3/BUILD.bazel

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ ng_module(
1919
"//packages:types",
2020
"//packages/common",
2121
"//packages/core",
22+
"@ngdeps//reflect-metadata",
2223
],
2324
)
2425

modules/benchmarks/src/tree/render3/BUILD.bazel

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ ng_module(
1717
"//packages:types",
1818
"//packages/common",
1919
"//packages/core",
20+
"@ngdeps//reflect-metadata",
2021
],
2122
)
2223

@@ -61,7 +62,6 @@ protractor_web_test(
6162
"//modules/benchmarks/src/tree:perf_lib",
6263
"@ngdeps//node-uuid",
6364
"@ngdeps//protractor",
64-
"@ngdeps//reflect-metadata",
6565
"@ngdeps//yargs",
6666
],
6767
)

packages/benchpress/BUILD.bazel

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,5 +15,6 @@ ts_library(
1515
"//packages:types",
1616
"//packages/core",
1717
"@ngdeps//@types/node",
18+
"@ngdeps//reflect-metadata",
1819
],
1920
)

packages/compiler-cli/integrationtest/bazel/ng_module/BUILD.bazel

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,18 @@ load("//packages/bazel:index.bzl", "ng_module")
22

33
ng_module(
44
name = "test_module",
5+
testonly = True,
56
srcs = glob(["*.ts"]),
67
compiler = "//packages/bazel/src/ngc-wrapped",
78
entry_point = "index.ts",
89
flat_module_out_file = "flat_module_filename",
910
module_name = "some_npm_module",
1011
ng_xi18n = "//packages/bazel/src/ngc-wrapped:xi18n",
1112
node_modules = "@ngdeps//typescript:typescript__typings",
13+
tags = [
14+
"fixme-ivy-aot",
15+
"no-ivy-jit",
16+
],
1217
deps = [
1318
"//packages/core",
1419
"@ngdeps//@types",
@@ -19,6 +24,7 @@ load(":extract_flat_module_index.bzl", "extract_flat_module_index")
1924

2025
extract_flat_module_index(
2126
name = "flat_module_index",
27+
testonly = True,
2228
deps = [":test_module"],
2329
)
2430

packages/core/test/bundling/animation_world/BUILD.bazel

Lines changed: 13 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,10 @@ load("//tools/http-server:http_server.bzl", "http_server")
77
ng_module(
88
name = "animation_world",
99
srcs = ["index.ts"],
10-
tags = ["ivy-only"],
10+
tags = [
11+
"ivy-only",
12+
"no-ivy-jit",
13+
],
1114
type_check = False, # see #26462
1215
deps = [
1316
"//packages/common",
@@ -25,7 +28,10 @@ ng_rollup_bundle(
2528
# has an "external" directory for external dependencies.
2629
# This should probably start with "angular/" and let the rule deal with it.
2730
entry_point = "packages/core/test/bundling/animation_world/index.js",
28-
tags = ["ivy-only"],
31+
tags = [
32+
"ivy-only",
33+
"no-ivy-jit",
34+
],
2935
deps = [
3036
":animation_world",
3137
"//packages/core",
@@ -39,6 +45,7 @@ js_expected_symbol_test(
3945
tags = [
4046
"ivy-aot",
4147
"ivy-only",
48+
"no-ivy-jit",
4249
],
4350
)
4451

@@ -51,4 +58,8 @@ http_server(
5158
":bundle.min.js",
5259
":bundle.min_debug.js",
5360
],
61+
tags = [
62+
"ivy-only",
63+
"no-ivy-jit",
64+
],
5465
)

packages/core/test/bundling/hello_world/BUILD.bazel

Lines changed: 18 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,10 @@ load("//tools/http-server:http_server.bzl", "http_server")
77
ng_module(
88
name = "hello_world",
99
srcs = ["index.ts"],
10-
tags = ["ivy-only"],
10+
tags = [
11+
"ivy-only",
12+
"no-ivy-jit",
13+
],
1114
deps = [
1215
"//packages/core",
1316
],
@@ -22,7 +25,10 @@ ng_rollup_bundle(
2225
# has an "external" directory for external dependencies.
2326
# This should probably start with "angular/" and let the rule deal with it.
2427
entry_point = "packages/core/test/bundling/hello_world/index.js",
25-
tags = ["ivy-only"],
28+
tags = [
29+
"ivy-only",
30+
"no-ivy-jit",
31+
],
2632
deps = [
2733
":hello_world",
2834
"//packages/core",
@@ -33,6 +39,10 @@ ts_library(
3339
name = "test_lib",
3440
testonly = True,
3541
srcs = glob(["*_spec.ts"]),
42+
tags = [
43+
"ivy-only",
44+
"no-ivy-jit",
45+
],
3646
deps = [
3747
"//packages:types",
3848
"//packages/core/testing",
@@ -50,6 +60,7 @@ jasmine_node_test(
5060
],
5161
tags = [
5262
"ivy-only",
63+
"no-ivy-jit",
5364
],
5465
deps = [":test_lib"],
5566
)
@@ -61,6 +72,7 @@ js_expected_symbol_test(
6172
tags = [
6273
"ivy-aot",
6374
"ivy-only",
75+
"no-ivy-jit",
6476
],
6577
)
6678

@@ -71,4 +83,8 @@ http_server(
7183
":bundle.min.js",
7284
":bundle.min_debug.js",
7385
],
86+
tags = [
87+
"ivy-only",
88+
"no-ivy-jit",
89+
],
7490
)

packages/core/test/bundling/hello_world_i18n/BUILD.bazel

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ load("//tools/http-server:http_server.bzl", "http_server")
66
ivy_ng_module(
77
name = "hello_world_i18n",
88
srcs = ["index.ts"],
9+
tags = ["ivy-only"],
910
deps = [
1011
"//packages/core",
1112
],
@@ -20,6 +21,7 @@ ng_rollup_bundle(
2021
# has an "external" directory for external dependencies.
2122
# This should probably start with "angular/" and let the rule deal with it.
2223
entry_point = "packages/core/test/bundling/hello_world_i18n/index.js",
24+
tags = ["ivy-only"],
2325
deps = [
2426
":hello_world_i18n",
2527
"//packages/core",
@@ -33,4 +35,5 @@ http_server(
3335
":bundle.min.js",
3436
":bundle.min_debug.js",
3537
],
38+
tags = ["ivy-only"],
3639
)

packages/core/test/bundling/hello_world_r2/BUILD.bazel

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,10 @@ load("//tools/http-server:http_server.bzl", "http_server")
77
ng_module(
88
name = "hello_world",
99
srcs = ["index.ts"],
10+
tags = [
11+
"ivy-only",
12+
"no-ivy-jit",
13+
],
1014
deps = [
1115
"//packages/core",
1216
"//packages/platform-browser-dynamic",
@@ -22,6 +26,10 @@ ng_rollup_bundle(
2226
# has an "external" directory for external dependencies.
2327
# This should probably start with "angular/" and let the rule deal with it.
2428
entry_point = "packages/core/test/bundling/hello_world_r2/index.js",
29+
tags = [
30+
"ivy-only",
31+
"no-ivy-jit",
32+
],
2533
deps = [
2634
":hello_world",
2735
"//packages/core",
@@ -33,6 +41,10 @@ ts_library(
3341
name = "test_lib",
3442
testonly = True,
3543
srcs = glob(["*_spec.ts"]),
44+
tags = [
45+
"ivy-only",
46+
"no-ivy-jit",
47+
],
3648
deps = [
3749
"//packages:types",
3850
"//packages/core/testing",
@@ -48,13 +60,21 @@ jasmine_node_test(
4860
":bundle.min.js.br",
4961
":bundle.min_debug.js",
5062
],
63+
tags = [
64+
"ivy-only",
65+
"no-ivy-jit",
66+
],
5167
deps = [":test_lib"],
5268
)
5369

5470
js_expected_symbol_test(
5571
name = "symbol_test",
5672
src = ":bundle.min_debug.js",
5773
golden = ":bundle.golden_symbols.json",
74+
tags = [
75+
"ivy-only",
76+
"no-ivy-jit",
77+
],
5878
)
5979

6080
http_server(
@@ -64,4 +84,8 @@ http_server(
6484
":bundle.min.js",
6585
":bundle.min_debug.js",
6686
],
87+
tags = [
88+
"ivy-only",
89+
"no-ivy-jit",
90+
],
6791
)

0 commit comments

Comments
 (0)